This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Export morph targets names into mesh.extra #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
changed the title
donmccurdy
reviewed
Jan 21, 2018
| if export_settings['gltf_morph']: | ||
| if blender_mesh.shape_keys is not None: | ||
| morph_max = len(blender_mesh.shape_keys.key_blocks) - 1 | ||
| if morph_max > 0: | ||
| weights = [] | ||
| targetNames = [] |
There was a problem hiding this comment.
Could you change the variable name to target_names here for consistency? (But exporting mesh['extras']['targetNames'] i agree with).
|
Done, thanks! |
donmccurdy
approved these changes
Jan 21, 2018
|
How should the names be used in case of multiple primitives? In our case there's three primitives in a single mesh and only one of them has morph targets. Therefore, should the morph target names be per primitive, instead of being global per mesh? Mesh morph weights appear to have similar problem, so maybe I'm mis-interpreting the spec? |
|
|
Aha! Thank you for pointing this out. |
|
/ping |
|
Looks good thanks! 👏 |
This was referenced Feb 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glTF 2.0 doesn't have morph target names in core spec.
But storing them into
mesh.extrais suggested in glTF spec issue thread KhronosGroup/glTF#1036Let's do that so far til morph target names is supported in core (maybe glTF next?) not to lose useful information.