Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Focus will frame target in view. #13165

Merged
merged 4 commits into from
Feb 27, 2018
Merged

Editor: Focus will frame target in view. #13165

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65a7e28
Focus will frame target in view. Object will only translate to focus …
Adam4lexander Jan 24, 2018
eab0344
Revert "Focus will frame target in view. Object will only translate t…
Adam4lexander Jan 24, 2018
f56fef8
Focus will frame target in view. Object will only translate to focus …
Adam4lexander Jan 24, 2018
26d9aa1
Removed isObject3D check
Adam4lexander Feb 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion examples/js/controls/EditorControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,36 @@ THREE.EditorControls = function ( object, domElement ) {

this.focus = function ( target ) {

if ( target === undefined ) {
return;
}

var box = new THREE.Box3().setFromObject( target );
object.lookAt( center.copy( box.getCenter() ) );

var targetDistance;

if ( box.isEmpty() ) {

// Focusing on an empty such as a light.

target.getWorldPosition( center );
targetDistance = 0.5;

} else {

center.copy( box.getCenter() );
targetDistance = box.getBoundingSphere().radius * 6;

}

var forwards = object.getWorldDirection().normalize();

var targetDelta = forwards.multiplyScalar( -targetDistance );

var targetWorldPosition = targetDelta.add( center );

object.position.copy( targetWorldPosition );

scope.dispatchEvent( changeEvent );

};
Expand Down