Editor: Focus will frame target in view. #13165
Conversation
…on target, will not rotate. Fixed a bug where empty's couldn't be focused on.
…o focus on target, will not rotate. Fixed a bug where empty's couldn't be focused on." This reverts commit 65a7e28.
…on target, will not rotate. Fixed a bug where empty's couldn't be focused on.
mrdoob
changed the title
| @@ -37,8 +37,36 @@ THREE.EditorControls = function ( object, domElement ) { | |||
|
|
|||
| this.focus = function ( target ) { | |||
|
|
|||
| if ( target === undefined || !target.isObject3D ) { | |||
There was a problem hiding this comment.
Hmm... groups, lights and cameras extend Object3D so I'm not sure about the last check here...
There was a problem hiding this comment.
That's the idea, this is only guarding against some random non-3d JavaScript object being passed in. The camera should focus on lights and cameras and groups too.
There was a problem hiding this comment.
Hmm, what random non-3d JavaScript object? And how could it get there?
There was a problem hiding this comment.
For example with the code: EditorControls.focus( 7 );
Maybe I'm being too protective... I can take it out if you think its not necessary?
I think it would only get there if the user made a mistake. So maybe it would be better for it to error in that case.
There was a problem hiding this comment.
Yeah, we don't do type checking in general. I would take it out 👍
|
Done. isObject3D check is removed |
|
Thanks! |
|
FYI I "mrdoobified" the code in 689306f 😇 |
This changes the EditorControls.focus behaviour in a few ways:
Will translate the camera to a distance proportional to the bounding box size of the target to frame it in the viewport.
The camera will only translate when focusing instead of rotating due to a lookAt call. I think this behaviour is more standard in 3d programs and I find the lookAt method to be a little disorienting.
Fixed a bug where the camera couldn't focus on empties which don't have geometries, such as lights or groups.