Skip to content

Conversation

@nicoeg
Copy link
Contributor

@nicoeg nicoeg commented Sep 5, 2019

Hey

The previous pr #572 missed a couple of references to the removed helper functions.
The fix in ResponseCallStrategy allowed it to generate docs in my Laravel 6 project.

@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #576   +/-   ##
=========================================
  Coverage     90.42%   90.42%           
  Complexity      299      299           
=========================================
  Files            14       14           
  Lines           710      710           
=========================================
  Hits            642      642           
  Misses           68       68
Impacted Files Coverage Δ Complexity Δ
.../Tools/ResponseStrategies/ResponseCallStrategy.php 87.6% <100%> (ø) 41 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741f6d1...c53c1c9. Read the comment docs.

@shalvah shalvah merged commit 8afe830 into mpociot:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants