Skip to content

Conversation

@sangnguyenplus
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #572   +/-   ##
=========================================
  Coverage     90.39%   90.39%           
  Complexity      298      298           
=========================================
  Files            14       14           
  Lines           708      708           
=========================================
  Hits            640      640           
  Misses           68       68
Impacted Files Coverage Δ Complexity Δ
src/Tools/Traits/ParamHelpers.php 100% <100%> (ø) 5 <0> (ø) ⬇️
src/Tools/Generator.php 95.93% <100%> (ø) 93 <0> (ø) ⬇️
...ols/ResponseStrategies/TransformerTagsStrategy.php 82% <100%> (ø) 26 <2> (ø) ⬇️
src/Tools/RouteMatcher.php 97.56% <100%> (ø) 19 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bc937...39187db. Read the comment docs.

@highsolutions
Copy link

Waiting for this PR :).

@veneliniliev
Copy link

please merge :)

@shalvah shalvah merged commit 11d0ed7 into mpociot:master Sep 4, 2019
@sangnguyenplus
Copy link
Contributor Author

We're also having problem with package mpociot/documentarian it requires illuminate/view 5.x 😢

@sangnguyenplus sangnguyenplus deleted the laravel-6-compatible branch September 4, 2019 16:11
@shalvah
Copy link
Contributor

shalvah commented Sep 4, 2019

🤷‍♂️
I'll try to reach out to @mpociot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants