Skip to content

[#2892] Remove en-US locale code from contributor email links #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikkCZ wants to merge 1 commit into from
Closed

[#2892] Remove en-US locale code from contributor email links #2860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kitsune/users/jinja2/users/email/contributor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</p>

<p>
<a href="{{ add_utm('https://support.mozilla.org/en-US/kb/contributor-news-resources', 'get-involved', source='new-contributor') }}">
<a href="{{ add_utm('https://support.mozilla.org/kb/contributor-news-resources', 'get-involved', source='new-contributor') }}">
{{ _('Click here to find out where to help.') }}
</a>
</p>
Expand All @@ -29,7 +29,7 @@

<ul>
<li>
{% trans url=add_utm('https://support.mozilla.org/en-US/questions?sort=requested&filter=no-replies', 'get-involved', source='new-contributor')%}
{% trans url=add_utm('https://support.mozilla.org/questions?sort=requested&filter=no-replies', 'get-involved', source='new-contributor')%}
<a href="{{ url }}">Forum Contributor</a>
- Answer user support questions that are
most-requested but have no replies.
Expand All @@ -56,7 +56,7 @@
{% endtrans %}
</li>
<li>
{% trans url=add_utm('https://support.mozilla.org/en-US/kb/localize-firefox-help', 'get-involved', source='new-contributor') %}
{% trans url=add_utm('https://support.mozilla.org/kb/localize-firefox-help', 'get-involved', source='new-contributor') %}
<a href="{{ url }}">L10N Contributor</a>
- Help to translate Firefox Help content
to your language.
Expand Down
6 changes: 3 additions & 3 deletions kitsune/users/jinja2/users/email/contributor.ltxt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ your skills, we will try to find the right use for them :)
{#- L10n: This is an email. Whitespace matters! -#}
{{ _('To help you find out where to help check this site:') }}

{{ add_utm('https://support.mozilla.org/en-US/kb/contributor-news-resources', 'get-involved', source='new-contributor') }}
{{ add_utm('https://support.mozilla.org/kb/contributor-news-resources', 'get-involved', source='new-contributor') }}

{#- L10n: This is an email. Whitespace matters! -#}
{{ _('There are several ways in which you can get involved:') }}
Expand All @@ -32,7 +32,7 @@ Forum Contributor - Answer user support questions that are
most-requested but have no replies:
{% endtrans %}

{{ add_utm('https://support.mozilla.org/en-US/questions?sort=requested&filter=no-replies', 'get-involved', source='new-contributor') }}
{{ add_utm('https://support.mozilla.org/questions?sort=requested&filter=no-replies', 'get-involved', source='new-contributor') }}

{#- L10n: This is an email. Whitespace matters! -#}
{% trans %}
Expand Down Expand Up @@ -66,7 +66,7 @@ L10N Contributor - Help to translate Firefox Help content
to your language:
{% endtrans %}

{{ add_utm('https://support.mozilla.org/en-US/kb/localize-firefox-help', 'get-involved', source='new-contributor') }}
{{ add_utm('https://support.mozilla.org/kb/localize-firefox-help', 'get-involved', source='new-contributor') }}
Copy link
Contributor

@glogiotatidis glogiotatidis May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that localize-firefox-help redirects to localize-mozilla-support but have you talked with the folks watching google analytics about this change? I suggest that you remove this change from this PR since it's unrelated anyway and if it's OK with the GA folks pull request seperatelly.

Copy link
Contributor Author

@MikkCZ MikkCZ May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slug reverted back. I will get in touch with them.


{#- L10n: This is an email. Whitespace matters! -#}
{% trans %}
Expand Down