Skip to content

Conversation

@MikkCZ
Copy link
Contributor

@MikkCZ MikkCZ commented May 7, 2016

r?

to your language:
{% endtrans %}

{{ add_utm('https://support.mozilla.org/en-US/kb/localize-firefox-help', 'get-involved', source='new-contributor') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that localize-firefox-help redirects to localize-mozilla-support but have you talked with the folks watching google analytics about this change? I suggest that you remove this change from this PR since it's unrelated anyway and if it's OK with the GA folks pull request seperatelly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slug reverted back. I will get in touch with them.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented May 13, 2016

@glogiotatidis is it all right now?

@glogiotatidis
Copy link
Contributor

Thanks for the PR. Due to ongoing discussions about the future of the platform we'll avoid working on any pull requests not directly related to security or maintenance. I've marked this pull request as "Platform Decision Pending" to flag it for later review.

@MikkCZ
Copy link
Contributor Author

MikkCZ commented Jun 27, 2016

@glogiotatidis can we merge this? Should be very easy to review.

@glogiotatidis
Copy link
Contributor

Closing PR since development has been halted. Thanks your contribution.

@MikkCZ MikkCZ changed the title Remove en-US locale code from contributor email links [#2892] Remove en-US locale code from contributor email links Jul 21, 2017
@MikkCZ MikkCZ deleted the contributor-email branch October 19, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants