[bug 1122539] Handle the 0 case #2352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsune/search/tests/test_api.py
Outdated
Contributor
There was a problem hiding this comment.
linter failed in travis because q1 isn't used.
If max_questions or max_documents (or both) are 0, then we should do the least amount of work and just return [].
Member
Author
|
^^^ Fixes the lint issue. |
Contributor
|
It seems like you only did this for the questions function, not the documents function? |
Member
Author
|
Oops--you're right. I thought it got called twice. I'll do another fix later today. |
This was referenced Jul 10, 2020
This was referenced Aug 16, 2020
This was referenced Mar 22, 2022
This was referenced Mar 23, 2022
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If max_questions or max_documents (or both) are 0, then we should do the
least amount of work and just return [].
r?