[Bug 1123420, 1122539] Refactor and improve search suggestion APIs. #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems cleaner to me, splitting out the unique question/answer parts.
Contributor
|
I like the refactor. Tests are happy. r+ |
rlr
added a commit
that referenced
this pull request
Feb 6, 2015
…ta-1123420 [Bug 1123420, 1122539] Refactor and improve search suggestion APIs.
Member
There was a problem hiding this comment.
You might want a:
if max_results == 0:
return []
That way if the max is 0, it's (almost) a no-op.
Member
There was a problem hiding this comment.
Bah--I just noticed this got merged already. I can do a PR with this change if you like.
Contributor
Author
There was a problem hiding this comment.
That sounds like a good change, go for it! Thanks for looking at this.
Member
|
The "max_* thing could be 0" thing is in a PR: #2352 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the search suggestion do two separate queries for data, which fixes that goofy thing they did to try and get enough of both document types. It also switches to pulling the questions from the DB and using the API serializer. This increases consistency with the rest of the API, and provides some data to BuddyUp that is needed for their UX that isn't in ES.
r?