This repository was archived by the owner on Apr 3, 2019. It is now read-only.
fix(tests): Add a helper function to close a window.#4038
Merged
Conversation
Use a helper function to close the current window and go back to the original window. The window will only be closed if it's not the last window. fixes #3902
Author
Spoke too soon. In any case, here's a PR to do what was asked, use a helper to only close the window if it's not the last. |
| if (handles.length > 1) { | ||
| return this.parent | ||
| .closeCurrentWindow() | ||
| .switchToWindow(tabName || ''); |
Contributor
There was a problem hiding this comment.
@shane-tomlinson should this throw if last window or no?
Author
There was a problem hiding this comment.
I never thought of that.
shane-tomlinson
force-pushed
the
issue-3902-closeCurrentWindow-helper
branch
from
219381a to
19b4802
Compare
Contributor
|
Yay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a helper function to close the current window and
go back to the original window. The window will only
be closed if it's not the last window.
fixes #3902
@vladikoff and @jrgm - r?
I am running the functional tests using Marionette with the mock-raven from #4013 (comment). So far, so good.