This repository was archived by the owner on Apr 3, 2019. It is now read-only.
Conversation
Contributor
Author
|
@shane-tomlinson could you please check if you get something like this: |
|
Yup, I see the same problem, it keeps complaining about accessing diff --git a/app/scripts/lib/raven-mock.js b/app/scripts/lib/raven-mock.js
new file mode 100644
index 0000000..e423528
--- /dev/null
+++ b/app/scripts/lib/raven-mock.js
@@ -0,0 +1,19 @@
+define(function (require, exports, module) {
+ 'use strict';
+
+ return {
+ captureException (err, extraContext) {
+ console.error(String(err), extraContext);
+ },
+
+ config () {
+ return this;
+ },
+
+ install () {
+ },
+
+ uninstall () {
+ }
+ }
+});
diff --git a/app/scripts/require_config.js b/app/scripts/require_config.js
index 8d9d24c..12774e8 100644
--- a/app/scripts/require_config.js
+++ b/app/scripts/require_config.js
@@ -41,7 +41,9 @@ require.config({
nocache: 'lib/requirejs-plugin-nocache',
passwordcheck: '../bower_components/fxa-password-strength-checker/build/fxa-password-strength-checker',
'p-promise': '../bower_components/p/p',
- raven: '../bower_components/raven-js/dist/raven',
+ //raven: '../bower_components/raven-js/dist/raven',
+ raven: 'lib/raven-mock',
+
sinon: '../bower_components/sinon/index',
sjcl: '../bower_components/sjcl/sjcl',
speedTrap: '../bower_components/speed-trap/dist/speed-trap', |
|
I spoke too soon, I eventaully start seeing this error:
|
|
Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1290966 Fix |
This was referenced Aug 11, 2016
|
Our avatar upload tests suffer from mozilla/geckodriver#168 |
|
Ref mozilla/geckodriver#176 - Any executeAsync call that we expect to timeout fails due to an unexpected error message being returned. |
| myProfile.setPreference('xpinstall.signatures.required', false); | ||
| // Firefox 48+ requires marionette settngs | ||
| myProfile.setPreference('marionette', true); | ||
| myProfile.setPreference('webdriver.gecko.driver', path.join(__dirname, 'node_modules', 'geckodriver', 'geckodriver')); |
Contributor
Author
There was a problem hiding this comment.
this doesn't really work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3995