-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes fennec migration code #5268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
opened mozilla-mobile/firefox-android#245, will wait until that, or some variation of it lands before I land this - then this will be a non-breaking change |
ee9255f
to
7cf2dbf
Compare
Codecov ReportBase: 44.30% // Head: 44.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5268 +/- ##
=======================================
Coverage 44.30% 44.30%
=======================================
Files 175 175
Lines 13898 13898
=======================================
Hits 6158 6158
Misses 7740 7740 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Change was landed in android-components, verified that building with this PR is not a breaking change! |
It's been a long time coming, but this PR finally removes the fennec to fenix migration code.
I won't land this until I have the PRs in firefox-android to remove the code there... or I might opt to land the removal there first, so this becomes a not-breaking change.
NOTE: Althought fenix no longer runs the migration, the code is still alive in android components last I checked, which is why this is "breaking"
Regardless opening a PR to get some eyes on it. This was very mechanical!
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[ff-android: firefox-android-branch-name]
and/or[fenix: fenix-branch-name]
to the PR title.