Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Bug 1803632 - Removes remaining Fennec to Fenix migration functions #245

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Bug 1803632 - Removes remaining Fennec to Fenix migration functions #245

merged 4 commits into from
Dec 1, 2022

Conversation

tarikeshaq
Copy link
Contributor

Removes bookmarks, visits and logins migration functions, so the related PR in application-services is not a breaking change.

This was mechanical and as far as I could search, non of those functions are used by Fenix anymore

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@tarikeshaq tarikeshaq added the 🕵️‍♀️ needs review PRs that need to be reviewed label Dec 1, 2022
@tarikeshaq tarikeshaq mentioned this pull request Dec 1, 2022
Merged
4 tasks
@jonalmeida
Copy link
Collaborator

This goes well with #134 too. 🙂

gabrielluong
gabrielluong approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gabrielluong gabrielluong removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Dec 1, 2022
@tarikeshaq tarikeshaq added the 🛬 needs landing (squash) PRs that are ready to land (squashed) label Dec 1, 2022
@mergify mergify bot merged commit 14255ca into mozilla-mobile:main Dec 1, 2022
@tarikeshaq tarikeshaq deleted the bug-1803632 branch December 1, 2022 22:05
@tarikeshaq
Copy link
Contributor Author

This goes well with #134 too. 🙂
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabrielluong gabrielluong gabrielluong approved these changes

Assignees
No one assigned
Labels
🛬 needs landing (squash) PRs that are ready to land (squashed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarikeshaq @jonalmeida @gabrielluong