Behavioral targeting event store queries #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddai
changed the title
jeddai
force-pushed
the
behavior-targeting-event-store-queries
branch
from
77aa9d2
to
55b8983
Compare
Codecov ReportBase: 41.89% // Head: 42.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
==========================================
+ Coverage 41.89% 42.69% +0.79%
==========================================
Files 173 174 +1
Lines 13267 13464 +197
==========================================
+ Hits 5558 5748 +190
- Misses 7709 7716 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jhugman
reviewed
Nov 7, 2022
4 tasks
…ehavior-targeting-event-store-queries
mhammond
pushed a commit
to mhammond/application-services
that referenced
this pull request
Nov 14, 2022
* add behavior event store query method * update test behavior to correctly use new methods * adjust query method and tests based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to query into the event store. This will be used to find core active users, as well as users meeting other behavior criteria.
#5206 must be merged first.
EXP-2643
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[ac: android-components-branch-name]and/or[fenix: fenix-branch-name]to the PR title.