Nimbus: Add EventCount store to persistence layer #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
force-pushed
the
travis/behavior-targeting-persistence
branch
2 times, most recently
from
8bc3f32
to
301e23f
Compare
Codecov ReportBase: 41.70% // Head: 41.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5206 +/- ##
==========================================
+ Coverage 41.70% 41.89% +0.18%
==========================================
Files 173 173
Lines 13204 13267 +63
==========================================
+ Hits 5507 5558 +51
- Misses 7697 7709 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
travis79
force-pushed
the
travis/behavior-targeting-persistence
branch
from
57a368b
to
a808e6a
Compare
travis79
force-pushed
the
travis/behavior-targeting-persistence
branch
from
a808e6a
to
98f9c2a
Compare
tarikeshaq
suggested changes
Nov 3, 2022
There was a problem hiding this comment.
Had a quick look, I have limited insights into how this all should work but commented on the I/O in the new function and a couple of nits!
Only putting Request Changes for the I/O, feel free to push back if we're confident that wouldn't cause any blocking of the main thread!
4 tasks
travis79
force-pushed
the
travis/behavior-targeting-persistence
branch
from
98f9c2a
to
4e2c283
Compare
tarikeshaq
approved these changes
Nov 4, 2022
This store will hold the data collected around the user behavior that will be used for the purpose of targeting and message triggers. - Updates to behavior.rs to make it serializable/deserializable - Add event_store to NimbusClient and and read persisted data on init
travis79
force-pushed
the
travis/behavior-targeting-persistence
branch
from
4e2c283
to
ff4cd3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This store will hold the data collected around the user behavior that will be used for the purpose of targeting and message triggers.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[ac: android-components-branch-name]and/or[fenix: fenix-branch-name]to the PR title.