This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix: Revert remote-settings-client integration #269
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Merge pull request #232 from Dexterp37/rs-client" - Integrate remote-settings-client * Revert "Merge pull request #260 from mozilla-services/kinto-url-with-v1" - Include `/v1` on the end of the remote settings URL we give to the RS client * Revert "Merge pull request #261 from mozilla-services/feat/259" don't hide inner errors in the log message * Revert "Merge pull request #262 from mozilla-services/gh-259" Fix intermittent failures with ReqwestClient
|
Note: this was not a simple revert, since there were multiple interacting PRs between when this landed and now. Please check carefully. |
|
The primary goal here was to unblock #267, which is failing for hard to diagnose reasons only with the new client. Once we have those tests, it will give us more confidence that the new client is working the same as the old one. |
I'll help diagnosing test failures this morning :) If we won't be able to solve this before your morning, let's merge this :-) /me runs against the clock... (and hits it) |
|
Looks like this is no longer required. See #273 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v1on the end of the remote settings URL we give to the RS client #260 from mozilla-services/kinto-url-with-v1"Fixes #268