This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(adm): Include /v1 on the end of the remote settings URL we give to the RS client
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the RS client The default value that remote-settings-client uses for the server includes the /v1 suffix, but ours doesn't. Add it back in so that we don't confuse the client.
pjenvey
approved these changes
Dec 7, 2021
|
This is something I think might help #259. If it does, I'm in the "I have no idea how this ever worked" camp (and yet, it works on my machine, even without this change). |
mythmon
force-pushed
the
kinto-url-with-v1
branch
from
e5e58d4
to
f89a3ad
Compare
|
I'm going to force-push to remove those commits, but I think that this means it is working better now. |
mythmon
force-pushed
the
kinto-url-with-v1
branch
from
b763ce0
to
f89a3ad
Compare
|
Ugh, this failure still happened to me with this patch. There is something else around it. |
mythmon
added a commit
that referenced
this pull request
Dec 8, 2021
* Revert "Merge pull request #232 from Dexterp37/rs-client" - Integrate remote-settings-client * Revert "Merge pull request #260 from mozilla-services/kinto-url-with-v1" - Include `/v1` on the end of the remote settings URL we give to the RS client * Revert "Merge pull request #261 from mozilla-services/feat/259" don't hide inner errors in the log message * Revert "Merge pull request #262 from mozilla-services/gh-259" Fix intermittent failures with ReqwestClient
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value that remote-settings-client uses for the server includes the /v1 suffix, but ours doesn't. Add it back in so that we don't confuse the client.