Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Issue #5935: Introduce setting for HTTPS-Only mode #5988

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

pocmo
Copy link
Contributor

@pocmo pocmo commented Dec 3, 2021

This patch introduces HTTPS-Only mode. It's a draft.

  • For the preference: Should we have a "learn more" URL in settings like desktop? (Desktop page)
  • Preference placement: Like desktop, I created a "Security" section, that contains SafeBrowsing and this new setting. Is that okay?
  • This is only a minimal version of the error page compared to desktop (See Add error pages for HTTPS ONLY MODE android-components#11306). The reason for that is that we do not support such rich error pages in A-C yet. But the error page is fully functional.
  • All strings I used are from desktop. Do they work for mobile?

CC @jeffreygee

https_only_setting

https_only_errorpage

@pocmo pocmo added UX 🕵️‍♀️ needs review PRs that need to be reviewed labels Dec 3, 2021
@pocmo
Copy link
Contributor Author

pocmo commented Dec 3, 2021

Needs A-C build with mozilla-mobile/android-components#11352

@pocmo pocmo linked an issue Dec 3, 2021 that may be closed by this pull request
@jeffreygee
Copy link

jeffreygee commented Dec 6, 2021

@pocmo

For the preference: Should we have a "learn more" URL in settings like desktop? (Desktop page) /
All strings I used are from desktop. Do they work for mobile? Yes, I think it's good to keep consistent with desktop. I will double check with our content designers to make sure

Preference placement: Like desktop, I created a "Security" section, that contains SafeBrowsing and this new setting. Is that okay? Looks good to me!

This is only a minimal version of the error page compared to desktop - Have we ever thought of having a secondary CTA/link below like 'Manage your settings' where we can viewport them back to their security settings?

What are your thoughts on setting the default state as toggled on to enhance the security experience for our users? Something we can probably discuss with the group in the weekly.

@pocmo
Copy link
Contributor Author

pocmo commented Dec 6, 2021

This is only a minimal version of the error page compared to desktop - Have we ever thought of having a secondary CTA/link below like 'Manage your settings' where we can viewport them back to their security settings?

That's an interesting idea. We would need to find a way to communicate this from our "error pages" component to the app. Not impossible. But something we need to figure out.

What are your thoughts on setting the default state as toggled on to enhance the security experience for our users? Something we can probably discuss with the group in the weekly.

That sounds great. Yeah, let's discuss this. Maybe this requires us to change the error page text though. Otherwise the user may not really understand it, if they haven't enabled this themselves? 🤔

@pocmo
Copy link
Contributor Author

pocmo commented Dec 7, 2021

Updated the PR.

  • HTTPS-Only mode is now behind a feature flag that is only enabled in Nightly (and debug builds)
  • The setting is now enabled by default

@pocmo pocmo marked this pull request as ready for review December 7, 2021 16:20
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pocmo pocmo added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Dec 8, 2021
@mergify mergify bot merged commit 72dc901 into mozilla-mobile:main Dec 8, 2021
@pocmo pocmo deleted the https-only branch December 8, 2021 15:11
@jeffreygee
Copy link

jeffreygee commented Dec 13, 2021

@pocmo I worked with one of our content designers for strings updates:

[Settings screen]
Header: HTTPS-only mode
Subheader: Automatically attempts to connect to sites using HTTPS for increased security. HTTPS connections provide a secure, encrypted connection to websites you visit.
CTA: Learn more

[Error Page]
Title: The site you requested does not support HTTPS
Body: By default, Firefox Focus attempts to connect using HTTPS for increased security. To change this setting or to learn more, go to Settings > Privacy & Security > Security.
CTA: Continue to HTTP Site

@pocmo
Copy link
Contributor Author

pocmo commented Dec 13, 2021

@jeffreygee Awesome, thank you! I will work on getting this updated in #6009.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a setting for indicating the HTTPS-Only Mode configuration
3 participants