Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add a setting for indicating the HTTPS-Only Mode configuration #5935

Closed
Amejia481 opened this issue Nov 23, 2021 · 6 comments · Fixed by #5988
Closed

Add a setting for indicating the HTTPS-Only Mode configuration #5935

Amejia481 opened this issue Nov 23, 2021 · 6 comments · Fixed by #5988
Assignees
@pocmo
Labels
E2 Estimation points: 2, easy, half a day to 2 days feature QAVerified

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Nov 23, 2021 •
edited
Loading

Users should be able to select the HTTPS-Only mode configuration.

This is the UI that we use in desktop, we should have something similar adapted to Focus UI.

image
@Amejia481
Copy link
Contributor Author

Related AC ticket mozilla-mobile/android-components#11305

@Amejia481
Copy link
Contributor Author

As Focus by policy we don't persist any information, I think we may not need to add a exception page

@Amejia481 Amejia481 mentioned this issue Nov 23, 2021
Closed
@Amejia481 Amejia481 added the E2 Estimation points: 2, easy, half a day to 2 days label Dec 1, 2021
@pocmo
Copy link
Contributor

pocmo commented Dec 2, 2021

Since Focus is always in private mode, I assume we only need an ON/OFF option here.

@Amejia481
Copy link
Contributor Author

Agree!

@pocmo pocmo self-assigned this Dec 3, 2021
pocmo added a commit to pocmo/focus-android that referenced this issue Dec 3, 2021
@pocmo
Issue mozilla-mobile#5935: Introduce setting for HTTPS-Only mode
71a3b49
pocmo added a commit to pocmo/focus-android that referenced this issue Dec 3, 2021
@pocmo
Issue mozilla-mobile#5935: Introduce setting for HTTPS-Only mode
911d504
@pocmo pocmo linked a pull request Dec 3, 2021 that will close this issue
Issue #5935: Introduce setting for HTTPS-Only mode #5988
Merged
@pocmo
Copy link
Contributor

pocmo commented Dec 3, 2021

Opened a draft PR that introduces the setting and uses the desktop strings:

https_only_setting

pocmo added a commit to pocmo/focus-android that referenced this issue Dec 7, 2021
@pocmo
Issue mozilla-mobile#5935: Introduce setting for HTTPS-Only mode
05bdaad
@mergify mergify bot closed this as completed in #5988 Dec 8, 2021
mergify bot pushed a commit that referenced this issue Dec 8, 2021
@pocmo @mergify
Issue #5935: Introduce setting for HTTPS-Only mode
72dc901
@lobontiumira
Copy link

Verified on the Focus Nightly 97.0 (build 353441046 GV 97.0a1-20211208095339) with Samsung Galaxy Note 8 (Android 9) that the new option HTTPS-Only Mode is displayed in Settings - Privacy & Security - Security area.
The toggle can be enabled/disabled without glitches.
The "Learn more" link when tapped redirects the user to https://support.mozilla.org/en-US/kb/https-only-prefs SUMO page.

Screenshot_4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
E2 Estimation points: 2, easy, half a day to 2 days feature QAVerified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5935: Introduce setting for HTTPS-Only mode pocmo/focus-android
3 participants
@pocmo @Amejia481 @lobontiumira