Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Use system WebView #379

Closed
bbinto opened this issue Jan 23, 2018 · 9 comments
Closed

Use system WebView #379

bbinto opened this issue Jan 23, 2018 · 9 comments
Assignees
@pocmo
Labels
size M 3 pts = 2-3 days = 12 - 18 hours
Milestone
Sprint 2 (3.0)

Comments

@bbinto
Copy link
Contributor

bbinto commented Jan 23, 2018 •
edited by mcomella
Loading

With this bug:

  • onFocusChangeListener should move to WebView

Follow-ups:
@mcomella
Copy link
Contributor

@bbinto Was there a new release of AmazonWebView?

@bbinto
Copy link
Contributor Author

bbinto commented Jan 23, 2018

No sure, Carter suggested to talk to their eng team for further details, probably should set something up with them next week.

This was referenced Feb 13, 2018
Closed
Open
Open
@mcomella mcomella changed the title Enable webview (v55/v59) to improve overall browser security Use system WebView May 15, 2018
@mcomella
Copy link
Contributor

mcomella commented May 15, 2018 •
edited
Loading

After testing, I can't see a perf difference between AmazonWebView and the platform WebView so let's just use the system WebView.

@liuche
Copy link
Contributor

liuche commented May 15, 2018

2018-05-15 15 38 38

Dropping this image here so I can link it elsewhere on the wiki. It also gives some context into where everything goes.

@liuche liuche mentioned this issue May 29, 2018
Open
This was referenced May 29, 2018
Closed
Closed
@liuche
Copy link
Contributor

liuche commented Jun 7, 2018

Oops, just to clarify, this is going to be the Amazon WebView underneath, but can be used just like the system webview.

@mcomella
Copy link
Contributor

I have a (bitrotted) WIP to do this: https://github.com/mcomella/firefox-tv/tree/rm-awv It should give you a good idea of what needs to change to do this.

@mcomella mcomella mentioned this issue Aug 21, 2018
Closed
@mcomella mcomella added this to the Sprint 1 (3.0) milestone Aug 21, 2018
@pocmo
Copy link
Contributor

pocmo commented Aug 22, 2018

FYI: We are working on getting browser-engine(-system) into a state that it can be used here. This will give us the system WebView too. However I think we will still need 1-3 weeks. I just wanted to let you know in case this helps you prioritizing.

@bbinto bbinto modified the milestones: Sprint 1 (3.0), Sprint 2 (3.0) Aug 24, 2018
@bbinto bbinto added the size M 3 pts = 2-3 days = 12 - 18 hours label Aug 24, 2018
@liuche liuche self-assigned this Aug 27, 2018
@pocmo
Copy link
Contributor

pocmo commented Aug 28, 2018

FYI: We are working on getting browser-engine(-system) into a state that it can be used here. This will give us the system WebView too. However I think we will still need 1-3 weeks. I just wanted to let you know in case this helps you prioritizing.

Filed #1039 for that.

@mcomella mcomella mentioned this issue Aug 28, 2018
Closed
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
fd94239 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
5c63721 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
@pocmo pocmo mentioned this issue Aug 29, 2018
Merged
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
2284d62 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
@liuche liuche assigned pocmo and unassigned liuche Aug 29, 2018
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 31, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
c118132 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 31, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
8b0e857 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 3, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
790dc50 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 3, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
ca9e7eb 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 5, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
2c69552 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 5, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
672c927 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit that referenced this issue Sep 5, 2018
@pocmo
Issue #1039: Use browser-engine-system and feature-session components…
996999e 
… to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue #379)
 * Removes the product flavor dimensions that are not needed anymore.
@pocmo
Copy link
Contributor

pocmo commented Sep 5, 2018

This happened as part of #1039.

@pocmo pocmo closed this as completed Sep 5, 2018
dnarcese pushed a commit to dnarcese/firefox-tv that referenced this issue Sep 6, 2018
@pocmo @dnarcese
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
71fd05f 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
dnarcese pushed a commit to dnarcese/firefox-tv that referenced this issue Sep 7, 2018
@pocmo @dnarcese
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
a035873 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
size M 3 pts = 2-3 days = 12 - 18 hours
Projects
None yet
Milestone
Sprint 2 (3.0)
Development

No branches or pull requests
4 participants
@pocmo @bbinto @mcomella @liuche