Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Replace webview abstraction layer with browser-engine-system component #1039

Closed
pocmo opened this issue Aug 28, 2018 · 6 comments
Closed

Replace webview abstraction layer with browser-engine-system component #1039

pocmo opened this issue Aug 28, 2018 · 6 comments
Assignees
@pocmo
Labels
P2 Medium impact and/or medium frequency
Milestone
Sprint 2 (3.0)

Comments

@pocmo
Copy link
Contributor

pocmo commented Aug 28, 2018

In the next Android components sprints we should have implemented all the functionality to start replacing the webview abstraction layer with browser-engine-system (WebView implementation of concept-engine).

I'm currently experimenting with a partially migrated build to identify missing pieces in our engine implementation.

As part of this migration we should be able to use the feature-session component here to automatically update the state (browser-session) from the engine events. With that we no longer need the Proxy and Callback objects.

With that finished Firefox for Fire TV should be the first app that uses the core components (browser-session <-> browser-engine-*). This will hopefully be the foundation to componetize more functionality and pull in other components that build on top of this core.
@pocmo pocmo self-assigned this Aug 28, 2018
@pocmo
Copy link
Contributor Author

pocmo commented Aug 28, 2018

I'm currently experimenting with a partially migrated build to identify missing pieces in our engine implementation.

For now I'll keep that assigned to me in order to continue this experiment. I filed this issue to track and document the work happening.

@pocmo pocmo mentioned this issue Aug 28, 2018
Closed
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 28, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
1727024 
…ion components to replace WebView abstraction layer.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 28, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
c95f877 
…ion components to replace WebView abstraction layer.
@bbinto bbinto added the P2 Medium impact and/or medium frequency label Aug 28, 2018
@bbinto bbinto added this to the Backlog (P2, P3) milestone Aug 28, 2018
@mcomella
Copy link
Contributor

@pocmo For v3.0, we want to replace AmazonWebView with the SystemWebView #379.

  1. Does this patch take this into account?
  2. Will this patch be ready for v3.0? fwiw, we have a lot of other changes in v3.0, which could already make things unstable so I wonder if we should wait for v3.1 (but that'd require us to do use the system WebView ourselves first).

@pocmo
Copy link
Contributor Author

pocmo commented Aug 29, 2018

@mcomella

Does this patch take this into account?

Yes. The integration of browser-engine-system will effectively cause a switch to the system's WebView.

Will this patch be ready for v3.0? fwiw, we have a lot of other changes in v3.0, which could already make things unstable so I wonder if we should wait for v3.1 (but that'd require us to do use the system WebView ourselves first).

What's the time frame for 3.0? According to the milestone it's September 19, 2018? This seems doable.

I wonder if we should wait for v3.1 (but that'd require us to do use the system WebView ourselves first).

I see issues with waiting. The WIP patch will rot and we will have to start the integration all over because too much has changed.

pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
dd7bfc3 
…ion components to replace WebView abstraction layer.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
4bab464 
…ion components to replace WebView abstraction layer.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
fd94239 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
5c63721 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 29, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
2284d62 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
@mcomella
Copy link
Contributor

mcomella commented Aug 29, 2018 via email

@pocmo
Copy link
Contributor Author

pocmo commented Aug 30, 2018

@mcomella I opened PR #1044 to share the current state. We should be able to provide most of the mentioned missing functionality in 0.21 tomorrow (not everything has landed yet though!).

Based on that what's your assessment of the risk compared to doing it later? My gut feeling is to get this in earlier than later and have the ability to iterate with the whole team on it (including QA) and identify problems.

Like with browser-toolbar for app X we are again committed to work towards your deadline and push out early component releases if needed.

pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 31, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
c118132 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Aug 31, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
8b0e857 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
@pocmo pocmo mentioned this issue Sep 3, 2018
Closed
16 tasks
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 3, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
790dc50 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 3, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
ca9e7eb 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 5, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
2c69552 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit to pocmo/firefox-tv that referenced this issue Sep 5, 2018
@pocmo
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
672c927 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
pocmo added a commit that referenced this issue Sep 5, 2018
@pocmo
Issue #1039: Use browser-engine-system and feature-session components…
996999e 
… to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue #379)
 * Removes the product flavor dimensions that are not needed anymore.
@pocmo
Copy link
Contributor Author

pocmo commented Sep 5, 2018

Merged. Follow-up work will continue in #1063.

@pocmo pocmo closed this as completed Sep 5, 2018
dnarcese pushed a commit to dnarcese/firefox-tv that referenced this issue Sep 6, 2018
@pocmo @dnarcese
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
71fd05f 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
dnarcese pushed a commit to dnarcese/firefox-tv that referenced this issue Sep 7, 2018
@pocmo @dnarcese
Issue mozilla-mobile#1039: Use browser-engine-system and feature-sess…
a035873 
…ion components to replace WebView abstraction layer.

As a side effect:
 * Replaces AmazonWebView with WebView (Issue mozilla-mobile#379)
 * Removes the product flavor dimensions that are not needed anymore.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
P2 Medium impact and/or medium frequency
Projects
None yet
Milestone
Sprint 2 (3.0)
Development

No branches or pull requests
4 participants
@pocmo @bbinto @mcomella @liuche