Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

[1630] Design for Center Focused Channel Vertically #1312

Closed
athomasmoz opened this issue Oct 17, 2018 · 10 comments
Closed

[1630] Design for Center Focused Channel Vertically #1312

athomasmoz opened this issue Oct 17, 2018 · 10 comments

Comments

@athomasmoz
Copy link

athomasmoz commented Oct 17, 2018

Why/User Benefit/User Problem

As a user, I want the tiles I'm looking at to be centered on the screen so it's easy to see where my remote is focused and I can see what's above & below before I click the arrows.

What / Requirements

  • The focused tile is centered between the top & bottom of the screen

image

Design

Source file is available on Google Drive ~/Firefox - Fire TV/Mocks/FTTV-Master.sketch

@athomasmoz athomasmoz added the needs ux Needs input from UX team label Oct 17, 2018
@athomasmoz athomasmoz added this to the v3.2 Backlog milestone Oct 17, 2018
@athomasmoz athomasmoz modified the milestones: v3.2 Backlog, v4.0 Backlog Oct 24, 2018
@aminalhazwani
Copy link
Contributor

aminalhazwani commented Oct 26, 2018

List of cases when the channel is focus in the center (red dashed line indicates half screen height). For example when the channel is not immediate after the toolbar.

image

Or when the channel is in the split screen.

image

Exceptions are: when channel is first after toolbar in non-split screen.

image

Or when is last channel.

image

@severinrudie
Copy link
Contributor

Blocked on #1669 (an intermediate state broken out of this story)

@mcomella
Copy link
Contributor

This seems to be a common implementation so look for existing solutions:

  • The Android TV support library
  • Various blog posts

@athomasmoz athomasmoz changed the title [1304] Center Focused Channel [1304] Center Focused Item Jan 25, 2019
@mcomella
Copy link
Contributor

@brampitoyo Is this something we might want to do? If not, please close. If so, can you rename the title to [1630] and maybe resurface it when we're focusing on homescreen polish? Hopefully, it'll come up sooner in triage though.

@brampitoyo brampitoyo changed the title [1304] Center Focused Item [1630] Center Focused Item May 19, 2019
@brampitoyo brampitoyo self-assigned this May 19, 2019
@brampitoyo
Copy link
Contributor

@mcomella Yes. This is something we want to do when we focus on homescreen polishes.

I will post the specs shortly.

@brampitoyo brampitoyo changed the title [1630] Center Focused Item [1630] Center Focused Channel Vertically May 19, 2019
@brampitoyo
Copy link
Contributor

@mcomella the specs was posted in #2238 (comment):

Whenever any channel needs to be vertically centred, it will have a 116dp padding to the top of the screen.

• Pinned site [is] vertically positioned at the centre of the screen.
• 3rd-to-last channel is still vertically centred.
• 2rd-to-last and last channels aren’t vertically centred. They are pinned to the bottom of the screen.

@brampitoyo brampitoyo removed their assignment May 20, 2019
@mcomella
Copy link
Contributor

This issue was blocked on split overlay work that is no longer relevant (source): removing "blocked" label.

@mcomella
Copy link
Contributor

@athomasmoz FYI: on the current homescreen, when navigating down from Pocket to Pinned Tiles, the screen scrolls so you can see the News & Politics section. However, when focusing the News & Politics section, the screen does not scroll so you can't see the categories below that. I wonder if this is preventing users from discovering more than News & Politics channel.

@brampitoyo
Copy link
Contributor

brampitoyo commented Jul 23, 2019

@athomasmoz This issue should be solved with the behaviour I’ve described above. Here are some illustrations to help clarify it.

  1. The toolbar and first channel don’t need to be vertically centred.


  1. Most other channels need to be centred. All vertically centred panels will have a 116dp padding to the top of the screen.



  1. second-to-last and last channel aren’t vertically centred. They’re pinned to the bottom of the screen.


@athomasmoz athomasmoz changed the title [1630] Center Focused Channel Vertically [1630] Design for Center Focused Channel Vertically Jul 23, 2019
@athomasmoz
Copy link
Author

UX completed. Implementation ticket #2573

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants