This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #19065: Add extension functions to be used with credit cards. #19187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielluong
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
Looking good here. Let's hold back on using this immediately until we land the breaking changes that are coming from AC/AS in #19154
| * to validate a credit card number | ||
| */ | ||
| @Suppress("MagicNumber") | ||
| fun String.validateCreditCardNumber(): Boolean { |
There was a problem hiding this comment.
Nice, this saves me the trouble of implementing the Luhn Algorithm. Just an FYI this will probably be refactored in some capacity when I finish up the credit card validation that will return the credit card issuer based on the card number in mozilla-mobile/android-components#9813.
One immediate benefit of having this for now is that we can probably use this for the form validation in the meantime in #18266.
app/src/test/java/org/mozilla/fenix/settings/creditcards/StringTest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/org/mozilla/fenix/settings/creditcards/StringTest.kt
Outdated
Show resolved
Hide resolved
gabrielluong
suggested changes
Apr 22, 2021
| * Strips characters other than digits from a string. | ||
| * Used to strip a credit card number user input of spaces and separators. | ||
| */ | ||
|
|
app/src/main/java/org/mozilla/fenix/settings/creditcards/String.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/creditcards/String.kt
Outdated
Show resolved
Hide resolved
| return luhnAlgorithmValidation(creditCardNumber) | ||
| } | ||
|
|
||
| private fun luhnAlgorithmValidation(creditCardNumber: String): Boolean { |
There was a problem hiding this comment.
I am wondering if we can write tests that just validates the luhn algorithm
gabrielluong
approved these changes
Apr 22, 2021
gabrielluong
added
pr:approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19065
Pull Request checklist
To download an APK when reviewing a PR: