Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add credit card provider models #9813

Closed
gabrielluong opened this issue Mar 2, 2021 · 1 comment · Fixed by #10281
Closed

Add credit card provider models #9813

gabrielluong opened this issue Mar 2, 2021 · 1 comment · Fixed by #10281
Assignees
@gabrielluong
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E3 Estimation points: 3
Milestone
90.0.0 🌳

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Mar 2, 2021 •
edited by data-sync-user
Loading

We should add data class for the various credit card providers (AMEX, MA, V, etc) with rules about their card number lengths, regexp to validate their card numbers, and anything that is needed.

We allocated a E3 estimate to buffer time to look up Desktop implementation of these credit card provider validations.

┆Issue is synchronized with this Jira Task
@gabrielluong gabrielluong added E5 Estimation points: 5 <autofill> Credit Card, Addresses and Logins autofill functionality labels Mar 2, 2021
@gabrielluong gabrielluong self-assigned this Mar 2, 2021
@gabrielluong gabrielluong mentioned this issue Mar 2, 2021
Closed
@gabrielluong gabrielluong added <cc> E3 Estimation points: 3 and removed E5 Estimation points: 5 labels Mar 2, 2021
@gabrielluong gabrielluong mentioned this issue Apr 7, 2021
Merged
3 tasks
This was referenced Apr 22, 2021
Merged
Closed
@gabrielluong gabrielluong added this to the 90.0.0 🌳 milestone May 13, 2021
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 17, 2021
@gabrielluong
Issue mozilla-mobile#9813
a4385e1
@mcarare
Copy link
Contributor

mcarare commented May 18, 2021

@gabrielluong Some questions:
In what module should this model live?
Do we have icon resources from UX for provider icons or should we use SVGs used in desktop Firefox? (Not all provider have a SVG, some just a png)

gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 18, 2021
@gabrielluong
Issue mozilla-mobile#9813
0169121
@gabrielluong gabrielluong mentioned this issue May 18, 2021
Merged
4 tasks
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 18, 2021
@gabrielluong
Issue mozilla-mobile#9813
529f582
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 19, 2021
@gabrielluong
Issue mozilla-mobile#9813
fb6fc0a
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 19, 2021
@gabrielluong
Issue mozilla-mobile#9813
b6edf78
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 19, 2021
@gabrielluong
Issue mozilla-mobile#9813
961c4fb
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
a0c759a
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
b833169
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
44ab256
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
7d50d8e
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
4289775
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 20, 2021
@gabrielluong
Issue mozilla-mobile#9813
35891f5
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 23, 2021
@gabrielluong
Issue mozilla-mobile#9813
8ef0e40
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 23, 2021
@gabrielluong
Issue mozilla-mobile#9813
c0d1962
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
020558a
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
7159626
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
d3d7f0e
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
82a5a02
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
ae2f791
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
d7efbf5
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
ef87e26
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
f66c7f6
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813
0b1c634
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 24, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
3ca42e7 
…types from a card number and retrieve their logos
@gabrielluong gabrielluong mentioned this issue May 24, 2021
Closed
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 25, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
74413b3 
…types from a card number and retrieve their logos
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 25, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
f120a37 
…types from a card number and retrieve their logos
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 25, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
48e76d5 
…types from a card number and retrieve their logos
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 25, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
02e550b 
…types from a card number and retrieve their logos
gabrielluong added a commit to gabrielluong/android-components that referenced this issue May 25, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
7c85669 
…types from a card number and retrieve their logos
@mergify mergify bot closed this as completed in #10281 May 25, 2021
mergify bot pushed a commit that referenced this issue May 25, 2021
@gabrielluong @mergify
Issue #9813 - Add CreditCardUtils to parse credit card types from a c…
2c756d7 
…ard number and retrieve their logos
grigoryk pushed a commit to gabrielluong/android-components that referenced this issue Sep 11, 2021
@gabrielluong
Issue mozilla-mobile#9813 - Add CreditCardUtils to parse credit card …
f8fdb96 
…types from a card number and retrieve their logos
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E3 Estimation points: 3
Projects
None yet
Milestone
90.0.0 🌳
3 participants
@gabrielluong @mcarare and others