-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Feature] Request desktop site from new tab menu #17800
Comments
Question: Will the state of the toggle be remembered between multiple new tabs? Or it is used just for the next tab navigation? |
It should be used just for the navigation within that tab. Additional new tabs should go back to the default of mobile view. |
So it will be just to load the desktop version without having to load the mobile one? (The same number of steps as requesting desktop version from a tab). I thought it was related to a feature request: #7039. |
In this case, I would need a more detailed description of this feature. What is intended for? Do we use this for topsites also? |
I think request #7039 will be important to solve later, but for the purposes of this bug, yes, it's just to load the desktop site without having to load the mobile site. It should work the same way as it currently does, where it doesn't reset back to off for that tab unless the user chooses to toggle it off. Yes, it should work for top sites. CC: @kbrosnan may be able to help with a more detailed info around this feature, since I believe he gave me the idea originally :). |
Waiting for feedback from @kbrosnan |
Confirmed with @csadilek that we can move ahead with this implementation without making the home screen a tab. We need to make sure that we are requesting desktop site on URL load, not loading and then toggling (see gecko engine toggle). When a user is on a new tab and turns Request Desktop Site ON, it will persist for that session (just like current behavior). If the user opens a new tab again, Request Desktop Site defaults back to OFF. The on/off state of this toggle only needs to be known until the session begins. I added some more info to the description at the top :) |
Verified on the debug build with AC: 75.0.20210405143037, a69f74ece, and GV 89.0a1-20210405094633 on Google Pixel (Android 10), Samsung Galaxy Note 8 (Android 9), and HTC 10 (Android 8):
@eliserichards please review and advise. Should I file a new issue for the behavior mentioned above? desktop.site.toggle.mp4 |
@lobontiumira To clarify for this bullet:
does the new opened page open in a new tab? |
@amedyne the new opened page opens in the same tab. I.e. wikipedia.org, bbc.com respects the desktop site, going in the same tab from link to link, opens all the links as desktop sites (in the same tab). |
@lobontiumira When you click on stories from getpocket.com they open in new tabs, not in the same one. So IMO it is expected they are to be loaded in a mobile mode tab. |
Closing as done :) |
Meta: #17796
Followup to #17770
UX point of contact: @violasong (Victoria)
Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1
Acceptance criteria
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: