[Meta] UX changes for three-dot menus

[eliserichards]

Breaking this out of #14320 for tracking purposes since there's a lot of discussion on that thread.

This work should be behind a feature flag

UX Figma designs (bottom right, labeled "Final designs"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

• Reordering for main menu: [Feature] Three-dot menu item reordering #17771
• Navigation, share, refresh on main menu: [Feature] Add navigation to three-dot menu #17802
• Add menu icons back: [Feature] Add three-dot menu icons back #17872
• Add open in app back: Add Open in app to the three-dot menu #18461
• Expanding/scrolling (incl. top toolbar vs bottom toolbar): [Feature] Make three-dot menu scrollable and expandable #17772
• New tab menu (reordering and nav): [Feature] Reorder New Tab three-dot menu and add navigation #17770
• Add/Edit bookmark button: [Feature] Add/Edit bookmark buttons in three-dot menu #17797
• Sign in to sync (depends on sync tabs decision in tabs tray, [SPIKE] Evaluate ability to have non-browser tabs in the tabs tray #14969 and Show Synced Tabs in a separate tab on the tabs tray #14117): [Feature] Three-dot menu Sync sign-in item #17798
• Extensions submenu: [Feature] Three-dot menu extensions item #17799
• Request desktop site from new tab: [Feature] Request desktop site from new tab menu #17800
• Change reader view "Appearance" menu item: [Feature] Reader view appearance controls in three-dot main menu #17971
• Remove feature flag: Enable three-dot menu design changes in Nightly #17870

UI Tests

• New tab menu: Update UI Tests For New Tab Menu Changes  #17840 - assigned to QA testing team (irios)
• Main menu: Update UI tests for Main Menu design changes #17979 - assigned to QA testing team (irios)

Open question: how will this work be affected by the Nimbus bookmarks test? Will the work overlap?

• We think the goal is more to test the platform, so it might be worth it to keep the experiment. The ultimate decision can be made by Vesta

---

Other work:

• This should be implemented behind a feature flag, which can be removed once it's finished (added in For #17771: three-dot menu reorder #17838)
• Make sure we have l10n translations
• Remove all of the actual icon resources that are no longer needed
• Accessibility must be addressed in this redesign (e.g. Talkback, labels)
• Add/remove telemetry where needed

┆Issue is synchronized with this Jira Task

[eliserichards]

Additional bugs/stories:

• Persist open in app in main menu: Add Open in app to the three-dot menu #18461
• Report site issues on Nightly/Debug: Include Report Site Issue on menu in nightly/debug #18032
• Margins for main navigation Browser menu should always show the navbar #18591 and [AC] Sticky footer Add a sticky footer RecyclerView android-components#9932
• [AC] Smart menu width in landscape mode [Bug] Browser menus can be too narrow android-components#9922
• [AC] Create menu item for Bookmark Add/Edit item Add a double functionality browser Menu Item android-components#9840

[Robbankz]

remove this foolishness yall fumbled

[stale]

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.