Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Feature] Three-dot menu extensions item #17799

Closed
eliserichards opened this issue Feb 3, 2021 · 8 comments · Fixed by #18459
Closed

[Feature] Three-dot menu extensions item #17799

eliserichards opened this issue Feb 3, 2021 · 8 comments · Fixed by #18459
Assignees
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:WebExtensions MR1 Issues that are needed for the MR1 2021 release. needs:ac Needs Android Component Work
Milestone

Comments

@eliserichards
Copy link
Contributor

eliserichards commented Feb 3, 2021

Meta: #17796
Followup to #17771

UX point of contact: @violasong (Victoria)

Figma designs (bottom right, labeled "Final design"): https://www.figma.com/file/NHu4cTmzfYgi3QJz5DIDWD/Fenix-Toolbar-Menus?node-id=0%3A1

Acceptance criteria

  • We are changing the label of Addons in the three-dot menu to "Extensions"
  • This change is in both the main three-dot menu and the new tab menu
  • States of the menu are as follows:
    • A user has extensions installed (it doesn't matter if they are enabled): see the right-pointing arrow
    • A user has no extensions installed: the right-pointing arrow should not be there, and the full menu item should be clickable
  • Clicking on the the arrow should navigate the user to the list of installed addons
  • Clicking on the main area of the menu item should navigate the user to the main addons list

Addons installed
image

No addons installed
image

┆Issue is synchronized with this Jira Task

@eliserichards eliserichards added Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:WebExtensions labels Feb 3, 2021
@eliserichards eliserichards changed the title [Feature] Three-dot menu extensions submenu [Feature] Three-dot menu extensions item Feb 3, 2021
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 3, 2021
@eliserichards eliserichards removed the needs:triage Issue needs triage label Feb 3, 2021
@eliserichards
Copy link
Contributor Author

Open question: are we changing the Addons Manager strings in all places?

@eliserichards eliserichards added the MR1 Issues that are needed for the MR1 2021 release. label Feb 18, 2021
@eliserichards eliserichards added the E2 Estimation Point: easy, half a day to 2 days label Feb 23, 2021
@violasong
Copy link
Collaborator

I believe so! (But double-checking with @topotropic re: we are changing the label of Addons to "Extensions" everywhere)

@mcarare mcarare added the needs:ac Needs Android Component Work label Mar 5, 2021
@mcarare
Copy link
Contributor

mcarare commented Mar 5, 2021

@violasong is there any decision regarding the "Report site issue" item? It will be placed in this menu, or it will be in the extensions menu (the functionality is provided by an extension)? This placement might influence the way we construct the menu in AC. Sorry if there is already info on this on the mocks, I did not notice it. Thank you!

@ghost
Copy link

ghost commented Mar 8, 2021

Why is there the Sig-in anyway?
There should not existing things that is not Frequently used...

@violasong
Copy link
Collaborator

"Report site issue" will be put in this menu for prerelease versions. (See this issue)

@mcarare
Copy link
Contributor

mcarare commented Mar 11, 2021

Opened mozilla-mobile/android-components#9873 for the AC changes.

@mcarare mcarare self-assigned this Mar 12, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Mar 12, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Mar 12, 2021
mcarare added a commit to mcarare/fenix that referenced this issue Mar 17, 2021
@mcarare
Copy link
Contributor

mcarare commented Mar 24, 2021

Notes for QA:

@LaurentiuApahideanSV
Copy link

Verified as fixed on the latest debug build downloaded on the 24th of March.

Devices used:

  • OnePlus 6T (Android 9)
  • Google Pixel 3 XL (Android 9)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Mar 24, 2021
@eliserichards eliserichards linked a pull request Apr 2, 2021 that will close this issue
3 tasks
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. Feature:Tabs Feature:WebExtensions MR1 Issues that are needed for the MR1 2021 release. needs:ac Needs Android Component Work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants