Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #8745 Remove OneTimeFxaPushReset from FxaPushSupportFeature #8774

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Conversation

Stuie
Copy link
Contributor

@Stuie Stuie commented Oct 22, 2020

Removing the OneTimeFxaPushReset class, its usages, and unit tests.

No tests were added because no code was added.

The reference browser does not refer to the removed class, so there's no PR to address this change on that repository.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@jonalmeida jonalmeida self-assigned this Oct 22, 2020
Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

Not merging this immediately though as we're investigating some push-related bugs and it's better to have fewer moving parts in this domain for a few days.

@jonalmeida jonalmeida linked an issue Oct 22, 2020 that may be closed by this pull request
@jonalmeida
Copy link
Contributor

Note for self: this can be landed by the end of the week.

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2020

This pull request has conflicts when rebasing. Could you fix it @Stuie? 🙏

@jonalmeida jonalmeida added the 🛬 needs landing PRs that are ready to land label Nov 3, 2020
@mergify mergify bot merged commit c7645df into mozilla-mobile:master Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OneTimeFxaPushReset from FxaPushSupportFeature
2 participants