Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove OneTimeFxaPushReset from FxaPushSupportFeature #8745

Closed
jonalmeida opened this issue Oct 19, 2020 · 0 comments · Fixed by #8774
Closed

Remove OneTimeFxaPushReset from FxaPushSupportFeature #8745

jonalmeida opened this issue Oct 19, 2020 · 0 comments · Fixed by #8774
Labels
good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Milestone
66.0.0 🍟

Comments

@jonalmeida
Copy link
Contributor

jonalmeida commented Oct 19, 2020 •
edited by data-sync-user
Loading

We needed this in Fenix Nightly to reset our push subscriptions to follow a new FxA push subscription format. Now that we're comfortable with everyone having migrated, we can remove this code from FxaPushSupportFeature and it's usages.

┆Issue is synchronized with this Jira Task
@jonalmeida jonalmeida added good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab labels Oct 19, 2020
@jonalmeida jonalmeida linked a pull request Oct 22, 2020 that will close this issue
Closes #8745 Remove OneTimeFxaPushReset from FxaPushSupportFeature #8774
Merged
4 tasks
@mergify mergify bot closed this as completed in #8774 Nov 3, 2020
mergify bot pushed a commit that referenced this issue Nov 3, 2020
@Stuie @mergify
Closes #8745 Remove OneTimeFxaPushReset from FxaPushSupportFeature
c7645df
@jonalmeida jonalmeida added this to the 66.0.0 milestone Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Highlights issues for Hacktoberfest contributors to help us! <push> Components: concept-push, lib-push-adm, lib-push-firebase, feature-push, feature-sendtab
Projects
None yet
Milestone
66.0.0 🍟
Development

Successfully merging a pull request may close this issue.

Closes #8745 Remove OneTimeFxaPushReset from FxaPushSupportFeature
1 participant
@jonalmeida