Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #6685 enable previously unsupported add-ons when available #6693

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Apr 16, 2020


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Apr 16, 2020
@Amejia481 Amejia481 requested a review from csadilek April 16, 2020 20:00
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #6693 into master will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6693      +/-   ##
============================================
+ Coverage     77.68%   77.70%   +0.02%     
+ Complexity     4734     4641      -93     
============================================
  Files           629      615      -14     
  Lines         23108    22734     -374     
  Branches       3411     3342      -69     
============================================
- Hits          17952    17666     -286     
+ Misses         3747     3693      -54     
+ Partials       1409     1375      -34     
Impacted Files Coverage Δ Complexity Δ
...feature/addons/migration/SupportedAddonsChecker.kt 92.39% <83.33%> (-0.72%) 0.00 <0.00> (ø)
.../mozilla/components/feature/addons/AddonManager.kt 96.99% <100.00%> (+0.09%) 24.00 <2.00> (ø)
...nts/feature/customtabs/CustomTabIntentProcessor.kt
...ustomtabs/feature/CustomTabSessionTitleObserver.kt
...ture/customtabs/verify/DigitalAssetLinksHandler.kt
...a/components/feature/customtabs/CustomTabsFacts.kt
...onents/feature/customtabs/CustomTabConfigHelper.kt
...feature/customtabs/store/CustomTabsServiceStore.kt
...eature/customtabs/feature/OriginVerifierFeature.kt
...nents/feature/customtabs/CustomTabWindowFeature.kt
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e796fa7...24e0130. Read the comment docs.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚑 ⭐

Two comments below :).

@Amejia481
Copy link
Contributor Author

bors r=csadilek,psymoon

@bors
Copy link

bors bot commented Apr 16, 2020

Build succeeded:

@bors bors bot merged commit 70ca599 into mozilla-mobile:master Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants