This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Closes #6685 enable previously unsupported add-ons when available #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amejia481
commented
Apr 16, 2020
...e/addons/src/main/java/mozilla/components/feature/addons/migration/SupportedAddonsChecker.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6693 +/- ##
============================================
+ Coverage 77.68% 77.70% +0.02%
+ Complexity 4734 4641 -93
============================================
Files 629 615 -14
Lines 23108 22734 -374
Branches 3411 3342 -69
============================================
- Hits 17952 17666 -286
+ Misses 3747 3693 -54
+ Partials 1409 1375 -34 Continue to review full report at Codecov.
|
csadilek
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚑 ⭐
Two comments below :).
...e/addons/src/main/java/mozilla/components/feature/addons/migration/SupportedAddonsChecker.kt
Outdated
Show resolved
Hide resolved
...e/addons/src/main/java/mozilla/components/feature/addons/migration/SupportedAddonsChecker.kt
Outdated
Show resolved
Hide resolved
psymoon
reviewed
Apr 16, 2020
components/feature/addons/src/main/java/mozilla/components/feature/addons/AddonManager.kt
Outdated
Show resolved
Hide resolved
bors r=csadilek,psymoon |
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge