-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Bug] Newly-available addons that were installed before Preview cannot be enabled #9994
Comments
This will be fixed after this pr lands mozilla-mobile/android-components#6693 and Fenix picks the new version on AC that contains it |
Oops, didn't realize an issue had been filed over there already. Didn't think to check. Thanks for fixing it so quickly! |
This should be fixed in master, @AndiAJ would you mind taking a look? :) Be aware that now we are enabling the newly supported add-ons when the notification is shown. |
Hi @Amejia481 , I've just checked this matter using a Google Pixel 3a (Android 10) using the following scenarios: 1st scenarioFennec → Fenix GV 76 from 4/6 → Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22► Video after migrating from Fenix GV 76 from 4/6 → Fenix GV 77 from 4/16❌ The Add-ons are disabled after the migration ► Video after migrating from Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22❌ The Add-ons are disabled after the migration 2nd scenarioFennec → Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22► Video after migrating Fennec → Fenix GV 77 from 4/16✔️ The Add-ons are enabled after the migration ► Video after Fenix GV 77 from 4/16 →Latest Fenix GV 77 from 4/22
Please review and share your thoughts. |
It seems to have been fixed (at least for me) so I'm gonna close this. |
Sorry, @AndiAJ would you mind re-testing. Test the latest build from master, as it will have the fix. Also be aware, if you have a previous open instance of Fenix, you have kills from the task switcher and open it again. |
@BeeeWall Thanks for verifying :) |
Oops, my bad then. |
Hi, verified as fixed after updating to the latest Performed the following updates: ► Video after migrating Fenix GV 77 from 4/16 ► Video after migrating to the latest Fenix GV 77 from 4/23 ✔️ Great job @Amejia481 ! |
We receive a report of this issue. It would be pretty helpful if QA can help us to determine if this still an issue. The user was using 77.0.0-beta.2 |
It will be ideal if we can test on Xiaomi devices, as it was the device where the user is experiencing the issue. |
Tested this with Xiaomi Redmi Note 8T (Android 9) on Nightly and Beta channels, and couldn't reproduce the issue.
For Fennec > Fenix GV 76 from 4/6 > Fenix GV 77 from 4/16 >Latest Fenix GV 77 from 4/22 > latest Beta 76.0.0-beta2 - addons were enabled on the last build. |
We can close this issue, as we discovered that the reported bug is not related to add-ons, it's due to some devices that are not able to run WorkManager, we are going to open a new issue for it. |
|
Steps to reproduce
Expected behavior
They will enable fine and work, just like the uBlock update did if you had uBlock previously, and just like newly-installed addons do.
Actual behavior
The addon says it's enabled, but it does not move to the Enabled section, and does not work when browsing. If the app is closed and reopened, the addon page shows it as disabled again.
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: