[Bug] New tab three-dot menu should be wider when not signed in

[eliserichards]

When we're signed in to sync, the menu is wide enough to see the whole "Desktop Site" string. But when we're signed out, "Desktop site" gets cut off. I think the minimum width should allow us to see that whole string (in En-US)

┆Issue is synchronized with this Jira Task

[eliserichards]

Tagging @violasong and @brampitoyo for feedback

[Username1-a]

Excuse me, but why not keeping current layout from stable Firefox ("Desktop site" string is absent from home/new tab page 3-dot menu since it doesn't have desktop layout)?

And narrower 3-dot menu, as before, I think looks a bit cleaner and easier on the eyes as it doesn't obstruct as much content

"Synced tabs" instead of that long email string looked pretty reasonable, too

[cadeyrn]

"Desktop site" string is absent from home/new tab page 3-dot menu since it doesn't have desktop layout

This is not for a desktop layout of the home screen but to request the desktop version of the website you intend to load in a new tab. For reference: Chrome also shows this option in the home screen menu.

And narrower 3-dot menu, as before, I think looks a bit cleaner and easier on the eyes as it doesn't obstruct as much content

"Synced tabs" instead of that long email string looked pretty reasonable, too

This is both off-topic. This issue is about the minimum width of the menu for users who are not signed in and therefore there is no e-mail-address in the menu. It's also not about the menu layout in general. See mozilla-mobile/fenix#17796 as meta issue for the new menu.

[Mugurell]

The menu is as wide as needed to show the widest menu item (with a maximum set).
Based on the first screenshot the menu can be wider if the "sign-in item" - widest item requests so but in the second screenshot the "desktop site item" - widest item gets cut off. So this seems to be a bug of this menu item which doesn't report the right width.

[sheikh-azharuddin]

But is it necessary to show the email address at all??
Because of this menu is getting wider

[Mugurell]

I though at first that this might be an Android bug so I've created a toy project in which to test the Android widget that that menu item uses - a SwitchCompat, also in the hope that this could be used to report the issue to Google.
But there all is working as expected.
So although there is almost nothing we do to configure that widget something is impacting the behavior.
And I saw that indeed the width that that item returns is wrong. It does not account for the left drawable so the menu item has space only for the text and the thumb but also layouts that left drawable which pushes the text to the right resulting in it being ellipsized.

[Mugurell]

This was a bug for which many planets had to be perfectly aligned:

• Because of the menu is highly dynamic - has a dynamic width (from DynamicWidthRecyclerView) and a dynamic height (from ExpandableLayout) it has to measure and even layout items even before having a Window in which to show them (this happening later in BrowserMenu).
• This Desktop site menu item is a SwitchCompat .. a TextView witch allows to set compound drawables and we do with that left desktop drawable.
• We are not setting a layout direction (hence the "inherit" default will be used) but are using relative positioning for that drawable.
• Because the layout direction is inherit but the item is not yet attachedToWindow() the inheritance chain is not complete and the layout direction cannot be resolved.
  If we'd set a different layout direction or used drawableLeft instead of drawableStart this bug would not happen.
• TextView has an interesting behavior: it will not show these drawables if they are set with a relative direction (as in dynamic layout direction (LTR / RTL)) and that direction cannot be resolved, that being checked in View#resolveDrawables.
• So the onMeasure() of TextView will not add the size and padding of the relative drawables if they are not showing (the drawable is available in TextView but does not exist in the mShowing array)

All this will lead to the item returning a smaller width to DynamicWidthRecyclerView.
But eventualy the item will be added to a Window and all these checks will ran again, this time all working as expected so that left drawable will be shown but in a menu which has been setup with a smaller width.

[Mugurell]

Moving the ticket to AC where I'll open a PR to fix it.

[Mugurell]

Moving the ticket from Fenix to AC wasn't the best choice.
We still need a way to track issues and verify them on Fenix, so I've created a new ticket there.

[Mugurell]

This was verified on Fenix - mozilla-mobile/fenix#19310 (comment)
Moving to Done.