Skip to content

List OpenSSL as build depend#68

Merged
tylerjw merged 1 commit intomoveit:ros2from
tylerjw:openssl-build-depend
Apr 23, 2021
Merged

List OpenSSL as build depend#68
tylerjw merged 1 commit intomoveit:ros2from
tylerjw:openssl-build-depend

Conversation

@tylerjw
Copy link
Copy Markdown
Member

@tylerjw tylerjw commented Apr 23, 2021

This is a dependency and it should be listed in the package.xml and should be required in the find_package call.

@tylerjw tylerjw requested a review from vatanaksoytezer April 23, 2021 20:43
@tylerjw tylerjw mentioned this pull request Apr 23, 2021
Closed
vatanaksoytezer
vatanaksoytezer approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown

@vatanaksoytezer vatanaksoytezer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't know how we didn't notice that before though and compiled stuff.

@tylerjw tylerjw merged commit 9257f7d into moveit:ros2 Apr 23, 2021
@tylerjw tylerjw deleted the openssl-build-depend branch April 23, 2021 21:00
@henningkayser henningkayser mentioned this pull request Jun 1, 2021
Closed
@henningkayser henningkayser mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tylerjw @vatanaksoytezer