-
Notifications
You must be signed in to change notification settings - Fork 706
Add support for mixed constraints with constrained planner #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 61.57% 61.56% -0.00%
==========================================
Files 274 274
Lines 24965 24966 +1
==========================================
Hits 15369 15369
- Misses 9596 9597 +1
Continue to review full report at Codecov.
|
df69ac1 to
68da677
Compare
AndyZe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it yet. The code changes look good and surprisingly simple though 👍
moveit_planners/ompl/ompl_interface/src/detail/ompl_constraints.cpp
Outdated
Show resolved
Hide resolved
…s.cpp Co-authored-by: AndyZe <[email protected]>
AdamPettinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems very straightforward and elegant. I played with this a bunch starting from moveit/moveit2_tutorials#421 as an example, and it looks really good! Namely: single orientation, single position (with volume == 0 and volume > 0), and 1 position + 1 orientation all seem to be planning successfully very quickly.
* Add support for mixed constraints * Update moveit_planners/ompl/ompl_interface/src/detail/ompl_constraints.cpp Co-authored-by: AndyZe <[email protected]> Co-authored-by: AndyZe <[email protected]> Co-authored-by: AndyZe <[email protected]>
|
The code looks strange to me. In the planning_context_manager.cpp, line 539 to line 544,, it still said "Mixed constraints are not supported", and it only allows one constraint based on the if statement. I think it is wrong. If so, what have you tested? |
Description
Adds support for using mixed constraint types (position and orientation) with OMPL's constrained planner.
Tutorial here: moveit/moveit2_tutorials#421
Checklist