Fix rounding issue when reading config parameter value #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3083 |
MichaIng
approved these changes
Dec 8, 2024
MichaIng
force-pushed
the
fix-noise_level-conversion-from-config
branch
from
f93b931 to
b1c0fb6
Compare
zagrim
commented
Dec 9, 2024
round() produces an integer already, if no explicit number of decimal places passed as 2nd parameter. Wrapping it into another int() is hence unnecessary. Signed-off-by: MichaIng <[email protected]>
MichaIng
force-pushed
the
fix-noise_level-conversion-from-config
branch
from
b1c0fb6 to
6f5768f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the config file parameter value conversion formula to match the one used in the opposite direction. It seemed to work now ok at least with UI setting values from 0% to 4% so the original 11+ yo version doesn't look like a deliberate tweak due to some oddity (unless the ways of Python doing rounding have changed from those times).