enh: remove unnecessary integer conversions

round() produces an integer already, if no explicit number of decimal places passed as 2nd parameter. Wrapping it into another int() is hence unnecessary. Arithmetic operations with non-numeric/invalid values produce meaningful error messages. Wrapping input values into int() before dividing or multiplying them, is hence unnecessary. Manually entered floats in UI input and config file are then mathematically correctly rounded, which however cannot cause a value drift in save/read cycles, since on both ends, the float is converted into an integer directly. Signed-off-by: MichaIng <[email protected]>
motioneye-project · Dec 8, 2024 · b1c0fb6 · b1c0fb6
1 parent 1518046
commit b1c0fb6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/motioneye/config.py b/motioneye/config.py
@@ -915,7 +915,7 @@ def motion_camera_ui_to_dict(ui, prev_config=None):
         'threshold_maximum': ui['max_frame_change_threshold'],
         'threshold_tune': ui['auto_threshold_tuning'],
         'noise_tune': ui['auto_noise_detect'],
-        'noise_level': max(1, int(round(int(ui['noise_level']) * 2.55))),
+        'noise_level': max(1, round(ui['noise_level'] * 2.55)),
         'lightswitch_percent': ui['light_switch_detect'],
         'event_gap': int(ui['event_gap']),
         'pre_capture': int(ui['pre_capture']),
@@ -1384,7 +1384,7 @@ def motion_camera_dict_to_ui(data):
         'auto_noise_detect': data['noise_tune'],
         'max_frame_change_threshold': data['threshold_maximum'],
         'auto_threshold_tuning': data['threshold_tune'],
-        'noise_level': round(int(data['noise_level']) / 2.55),
+        'noise_level': round(data['noise_level'] / 2.55),
         'light_switch_detect': data['lightswitch_percent'],
         'despeckle_filter': data['despeckle_filter'],
         'event_gap': int(data['event_gap']),