Skip to content

docker/unified: vulkan build fixes#600

Merged
mostlygeek merged 3 commits intomainfrom
unified-vulkan-update-base
Mar 25, 2026
Merged

docker/unified: vulkan build fixes#600
mostlygeek merged 3 commits intomainfrom
unified-vulkan-update-base

Conversation

@mostlygeek
Copy link
Copy Markdown
Owner

@mostlygeek mostlygeek commented Mar 25, 2026

multiple fixes to vulkan build:

  • use ubuntu 26.04 to be compatible with AMD 395+ (Strix halo) hardware
  • add home directory in container
  • fix stable-diffusion install to actually enable vulkan

mostlygeek and others added 3 commits March 25, 2026 10:46
- Create home directory for llama-swap user to allow Vulkan shader cache
- Add -DSD_VULKAN=ON flag to stable-diffusion.cpp vulkan build

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add boolean inputs to selectively enable/disable CUDA and Vulkan builds
when manually triggering the unified Docker workflow. Both default to true.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

Walkthrough

This PR adds conditional backend build controls via workflow_dispatch inputs to the GitHub Actions workflow, upgrades the Vulkan builder's Ubuntu base image from 22.04 to 26.04, replaces LunarG Vulkan SDK installation with native Ubuntu packages, adds --break-system-packages to pip dependencies, adjusts user creation flags, and enables the SD_VULKAN CMake option during Vulkan builds.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/unified-docker.yml
Added build_cuda and build_vulkan boolean workflow_dispatch inputs (both default true), replacing fixed backend matrix with conditional exclusion logic to selectively skip backends based on input values.
Docker Image Setup
docker/unified/Dockerfile
Upgraded Vulkan base image to ubuntu:26.04, replaced LunarG Vulkan SDK installation with Ubuntu native packages (libvulkan-dev, glslang-tools, spirv-tools, vulkan-validationlayers, glslc). Added --break-system-packages to pip install and changed llama-swap user creation from --no-create-home to --create-home.
Build Script
docker/unified/install-sd.sh
Added -DSD_VULKAN=ON CMake flag when BACKEND is set to vulkan, alongside existing GGML_VULKAN=ON configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docker/unified: vulkan build fixes' accurately describes the main changes across the PR, which focus on fixing Vulkan builds through container updates, build flags, and workflow controls.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description accurately describes the key changes: Ubuntu 26.04 upgrade for AMD hardware compatibility, home directory fix for shader caching, and Vulkan build flag enabling in stable-diffusion install script.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch unified-vulkan-update-base

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mostlygeek mostlygeek changed the title docker/unified: fix sd.cpp vulkan build docker/unified: vulkan build fixes Mar 25, 2026
@mostlygeek mostlygeek merged commit 8fabc75 into main Mar 25, 2026
1 of 2 checks passed
@mostlygeek mostlygeek deleted the unified-vulkan-update-base branch March 25, 2026 14:26
rohitpaul pushed a commit to rohitpaul/llama-swap that referenced this pull request Mar 29, 2026
multiple fixes to vulkan build: 

- use ubuntu 26.04 to be compatible with AMD 395+ (Strix halo) hardware
- add home directory in container 
- fix stable-diffusion install to actually enable vulkan

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant