.github,docker/unified: improve caching and fix bugs#598
Merged
mostlygeek merged 4 commits intomainfrom Mar 23, 2026
Merged
Conversation
The GHA cache has a limit of 10GB which the docker layers and ccache already exceeds. Switching to the registry type cache does not have that limit and will help eliminate unnecessary recompiling work.
- add llama-swap user - set ENTRYPOINT to llama-swap - remove unnecessary steps from runtime container
- Resolve llama-swap git ref to full commit hash (same as other projects) - Update install-llama-swap.sh to map commit hash back to release tag - Enable daily cron schedule matching containers.yml (37 5 * * *) - Default all cpp refs to master, llama-swap to main - Enable GHCR push with dated tag (unified-YYYY-MM-DD) - Use registry cache only on real GHA runs (skip under act) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
WalkthroughThe PR updates the unified Docker workflow and build pipeline to use master/main branches as defaults for dependencies, enables Container Registry publishing in CI/CD environments (excluding local test runs), refactors version resolution to work with commit hashes and GitHub tags, introduces configuration management via example YAML, and changes the container entrypoint from interactive bash to the llama-swap service. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rohitpaul
pushed a commit
to rohitpaul/llama-swap
that referenced
this pull request
Mar 29, 2026
- set up a GHA scheduled job to build the container nightly - enabling pushing a llama-swap:unified and a llama-swap:unified-Y-M-D image to ghcr.io - tidy up Dockerfile to use a non-root user and llama-swap as an entry point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.