-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configuration API returns wrong store_name
#641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 60.92% 60.93% +0.01%
==========================================
Files 120 120
Lines 6377 6384 +7
==========================================
+ Hits 3885 3890 +5
- Misses 2120 2121 +1
- Partials 372 373 +1
Continue to review full report at Codecov.
|
Thanks for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wenxuwan 替换好了 |
上图里面Init函数的入参config里面的storeName现在是个空值,你需要在我贴的图的代码处给他复制成name,然后sub的时候就不需要再重新赋值了。 |
apollo的实现也有同样的问题,可以一起修复掉 |
使用apollo的默认配置报错了。能改回原来的配置吗,方便测试。 |
什么意思?可以本地改一下配置文件,进行测试。 |
@wenxuwan apollo部分已修复,有空麻烦review一下 |
please fix Layotto Env Pipeline 🌊 / 🍀 DeadLink Validation (pull_request) |
这个deadLink该怎么修复呢,有时候检查能过,有时候会失败 |
@MichaelDeSteven 有的url 不太稳定,可能在跑ci的时候 github 容器调那个url调不通、就报错了;这种时候重试下(重新运行下 workflow )就行啦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does:
Which issue(s) this PR fixes:
Fixes #613
Special notes for your reviewer:
Does this PR introduce a user-facing change?: