Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: configuration API returns wrong app_id and store_name #613

Closed
seeflood opened this issue May 28, 2022 · 7 comments · Fixed by #629 or #641
Closed

bug: configuration API returns wrong app_id and store_name #613

seeflood opened this issue May 28, 2022 · 7 comments · Fixed by #629 or #641
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed kind/bug

Comments

@seeflood
Copy link
Member

What happened:
When I play with the configuration API demo, I found that the demo printed some message with wrong app_id and store_name:

image

What you expected to happen:
Return correct app_id and store_name

How to reproduce it (as minimally and precisely as possible):
Run the demo in https://mosn.io/layotto/#/zh/start/configuration/start

Anything else we need to know?:

@seeflood seeflood added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels May 28, 2022
@MichaelDeSteven
Copy link
Contributor

plz assign the task to me

@seeflood
Copy link
Member Author

@MichaelDeSteven ok. Thanks!
Your avatar is cool

@MichaelDeSteven
Copy link
Contributor

@seeflood hhh,thanks

@seeflood
Copy link
Member Author

seeflood commented Jun 7, 2022

#629 fixed the wrong app_id
Now the wrong store_name is waiting to be fixed

@MichaelDeSteven
Copy link
Contributor

MichaelDeSteven commented Jun 7, 2022

All right. I will fix it.
BTW, what is the expected of store_name in this demo.

@seeflood
Copy link
Member Author

seeflood commented Jun 7, 2022

@MichaelDeSteven You can check the doc https://mosn.io/layotto/#/zh/start/configuration/start
It should be "config_demo":
image
It might be not easy to fix it. We can discuss

@MichaelDeSteven
Copy link
Contributor

@MichaelDeSteven You can check the doc https://mosn.io/layotto/#/zh/start/configuration/start It should be "config_demo": image It might be not easy to fix it. We can discuss

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed kind/bug
Projects
None yet
2 participants