Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Dapr pubsub API #406

Closed
wants to merge 14 commits into from
Closed

feature: add Dapr pubsub API #406

wants to merge 14 commits into from

Conversation

LXPWing
Copy link
Member

@LXPWing LXPWing commented Mar 6, 2022

What this PR does:
add Dapr pubsub API #361

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #406 (80d99a6) into main (b3a9740) will increase coverage by 3.02%.
The diff coverage is 55.90%.

❗ Current head 80d99a6 differs from pull request most recent head 3c813e2. Consider uploading reports for the commit 3c813e2 to get more accurate results

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   56.73%   59.75%   +3.02%     
==========================================
  Files          48      118      +70     
  Lines        2057     6406    +4349     
==========================================
+ Hits         1167     3828    +2661     
- Misses        768     2210    +1442     
- Partials      122      368     +246     
Impacted Files Coverage Δ
components/lock/etcd/etcd_lock.go 80.00% <ø> (ø)
components/lock/zookeeper/zookeeper_lock.go 64.28% <ø> (ø)
components/pkg/utils/consul.go 0.00% <0.00%> (ø)
components/pkg/utils/mongo.go 0.00% <0.00%> (ø)
components/pkg/utils/redis.go 0.00% <0.00%> (ø)
components/rpc/callback/callback.go 55.55% <ø> (ø)
components/rpc/invoker/mosn/channel/channel.go 33.33% <ø> (ø)
components/rpc/invoker/mosn/channel/connpool.go 86.04% <ø> (ø)
components/rpc/invoker/mosn/mosninvoker.go 65.00% <ø> (ø)
components/rpc/types.go 53.84% <ø> (ø)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a9740...3c813e2. Read the comment docs.

@seeflood seeflood self-requested a review March 7, 2022 02:11
@seeflood seeflood self-assigned this Mar 7, 2022
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late,I'm on call these days 😢
It looks good,but could u also modify the pkg/grpc/default_api/api_pubsub.go and convert the Layotto pubsub API to Dapr pubsub API?
You can take #377 and #362 as examples.

For example, the DeleteBulkState API in pkg/grpc/default_api/api_state.go just convert the request to dapr API request,and invoke Dapr API:

func (a *api) DeleteBulkState(ctx context.Context, in *runtimev1pb.DeleteBulkStateRequest) (*empty.Empty, error) {

The same thing can be done with the pubsub API

@LXPWing LXPWing closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants