-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add Dapr pubsub API #406
Conversation
Codecov Report
@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 56.73% 59.75% +3.02%
==========================================
Files 48 118 +70
Lines 2057 6406 +4349
==========================================
+ Hits 1167 3828 +2661
- Misses 768 2210 +1442
- Partials 122 368 +246
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late,I'm on call these days 😢
It looks good,but could u also modify the pkg/grpc/default_api/api_pubsub.go
and convert the Layotto pubsub API to Dapr pubsub API?
You can take #377 and #362 as examples.
For example, the DeleteBulkState
API in pkg/grpc/default_api/api_state.go
just convert the request to dapr API request,and invoke Dapr API:
layotto/pkg/grpc/default_api/api_state.go
Line 106 in 5234a80
func (a *api) DeleteBulkState(ctx context.Context, in *runtimev1pb.DeleteBulkStateRequest) (*empty.Empty, error) { |
The same thing can be done with the pubsub API
What this PR does:
add Dapr pubsub API #361