Add support for Dapr InvokeService and InvokeBinding API #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 56.53% 57.62% +1.09%
==========================================
Files 47 48 +1
Lines 2220 2289 +69
==========================================
+ Hits 1255 1319 +64
- Misses 827 837 +10
+ Partials 138 133 -5
Continue to review full report at Codecov.
|
zhenjunMa
approved these changes
Dec 14, 2021
4 tasks
MoonShining
approved these changes
Dec 14, 2021
nobodyiam
reviewed
Dec 31, 2021
| "testing" | ||
| ) | ||
|
|
||
| func Test_addPathSeparator(t *testing.T) { |
There was a problem hiding this comment.
Why is there no test logic related to etcd, as this file is actually etcd_test.go?
nobodyiam
reviewed
Dec 31, 2021
| } | ||
|
|
||
| func (d *daprGrpcAPI) startSubscribing() error { | ||
| // TODO |
There was a problem hiding this comment.
It's better to record what to do here, in case no one would know what to do here in the future
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for Dapr InvokeService and InvokeBinding API
Which issue(s) this PR fixes:
#361
Special notes for your reviewer:
Does this PR introduce a user-facing change?: