Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ut fails in components package #363

Closed
4 tasks done
seeflood opened this issue Dec 14, 2021 · 6 comments · Fixed by #364
Closed
4 tasks done

Ut fails in components package #363

seeflood opened this issue Dec 14, 2021 · 6 comments · Fixed by #364
Labels
help wanted Extra attention is needed

Comments

@seeflood
Copy link
Member

seeflood commented Dec 14, 2021

What happened:
Ut fails when testing components package.
I fixed the compilation errors of the ut in #362 .
But there are still some test failures:
image

  • fix ut for zookeeper lock . assigned to @ZLBer
  • fix ut for etcd sequencer. assigned to @whalesongAndLittleFish
  • modify the configuration to test components package in our CI pipeline
  • fix ut for RPC

What you expected to happen:
All code pass ut successfully

How to reproduce it (as minimally and precisely as possible):

go test components

Anything else we need to know?:

@seeflood seeflood added the help wanted Extra attention is needed label Dec 14, 2021
@seeflood
Copy link
Member Author

seeflood commented Dec 14, 2021

@ZLBer Hi, could you help fix the zookeeperLock test cases?
It seems that they are wrong from the very begining 😢

@whalesongAndLittleFish
Copy link
Contributor

I want to try to fix the unit test of etcd sequencer,please assign to me

@seeflood
Copy link
Member Author

@whalesongAndLittleFish Cool,Thanks!
assigned to you

@ZLBer
Copy link
Member

ZLBer commented Dec 14, 2021

@seeflood sure i will fix zk lock ut

@ZLBer ZLBer mentioned this issue Dec 14, 2021
@seeflood
Copy link
Member Author

image
update: I just found that RPC tests are not stable and sometimes fail

@seeflood
Copy link
Member Author

All fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants