Skip to content

params: set Jade fork activation times for mainnet and Hoodi#296

Merged
FletcherMan merged 2 commits intomainfrom
feat/set-jade-fork-times
Mar 13, 2026
Merged

params: set Jade fork activation times for mainnet and Hoodi#296
FletcherMan merged 2 commits intomainfrom
feat/set-jade-fork-times

Conversation

@FletcherMan
Copy link
Copy Markdown
Collaborator

@FletcherMan FletcherMan commented Mar 12, 2026

Summary

  • Set Jade fork activation timestamp for Hoodi (chain 2910): 1774418400 (2026-03-25 06:00 UTC)
  • Set Jade fork activation timestamp for Mainnet (chain 2818): 1775628000 (2026-04-08 06:00 UTC)

Both timestamps are after their respective EmeraldTime values, satisfying the fork ordering constraint (Morph203 < Viridian < Emerald < Jade).

Test plan

  • go build ./params/... — compiles successfully
  • go test ./params/... — all tests pass

Summary by CodeRabbit

  • Chores
    • Added Jade Fork activation times to Morph Hoodi and Morph Mainnet network configurations so the fork timing is included in chain parameters.
    • Bumped the package version (minor and patch increments) to reflect these configuration updates.

Set Jade upgrade timestamps:
- Hoodi (chain 2910): 2026-03-25 14:00 Beijing (1774418400)
- Mainnet (chain 2818): 2026-04-08 14:00 Beijing (1775628000)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@FletcherMan FletcherMan requested a review from a team as a code owner March 12, 2026 09:09
@FletcherMan FletcherMan requested review from tomatoishealthy and removed request for a team March 12, 2026 09:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2026

📝 Walkthrough

Walkthrough

Added an exported JadeForkTime (*uint64) field to params.ChainConfig, initialized it for MorphHoodiChainConfig and MorphMainnetChainConfig, and updated package version constants (VersionMinor, VersionPatch) in params/version.go.

Changes

Cohort / File(s) Summary
Chain configuration changes
params/config.go
Added JadeForkTime *uint64 to ChainConfig, included it in the struct's JSON/string output, and set JadeForkTime for MorphHoodiChainConfig (1774418400) and MorphMainnetChainConfig (1775628000).
Version bump
params/version.go
Updated VersionMinor from 1 to 2 and VersionPatch from 2 to 0, changing the package version constants.
Module file
go.mod
Touched (lines changed: +2/-0) — likely minor module metadata update accompanying changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • tomatoishealthy
  • r3aker86
  • curryxbo

Poem

🐰 In configs green I hop and peep,
A Jade timestamp I softly keep,
Two chains now marked, a tiny chime,
Time set in code — hooray for rime! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: setting Jade fork activation times for two networks (mainnet and Hoodi), which aligns with the primary modifications to ChainConfig fields and version bump in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/set-jade-fork-times
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
params/config.go (1)

393-396: ⚠️ Potential issue | 🟡 Minor

Add JadeForkTime to test chain configurations.

The test chain configs (AllEthashProtocolChanges, AllCliqueProtocolChanges, TestChainConfig, TestNoL1DataFeeChainConfig) initialize time-based forks (Morph203Time, ViridianTime, EmeraldTime) to new(uint64) but omit JadeForkTime. This causes IsJadeFork() to return false for tests using these global configs.

While tests that specifically test jade fork behavior work around this by creating custom chain configs with JadeForkTime explicitly set, any test using the global configs that relies on IsJadeFork() behavior (e.g., for MorphTx V1 validation in block_validator.go) will see it return false, potentially masking bugs.

For consistency with other time-based forks in these configs, JadeForkTime should be set to new(uint64).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@params/config.go` around lines 393 - 396, The test chain configs
(AllEthashProtocolChanges, AllCliqueProtocolChanges, TestChainConfig,
TestNoL1DataFeeChainConfig) initialize Morph203Time, ViridianTime, and
EmeraldTime to new(uint64) but omit JadeForkTime, causing IsJadeFork() to return
false in tests; update each of those config initializers to also set
JadeForkTime: new(uint64) so the global test configs behave like the others and
tests (e.g., MorphTx V1 validation in block_validator.go that calls IsJadeFork)
see the fork enabled by default.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@params/config.go`:
- Around line 393-396: The test chain configs (AllEthashProtocolChanges,
AllCliqueProtocolChanges, TestChainConfig, TestNoL1DataFeeChainConfig)
initialize Morph203Time, ViridianTime, and EmeraldTime to new(uint64) but omit
JadeForkTime, causing IsJadeFork() to return false in tests; update each of
those config initializers to also set JadeForkTime: new(uint64) so the global
test configs behave like the others and tests (e.g., MorphTx V1 validation in
block_validator.go that calls IsJadeFork) see the fork enabled by default.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 417538d8-bf8a-4bbc-98fc-3dc3e094cc62

📥 Commits

Reviewing files that changed from the base of the PR and between ea85a8b and 6d289c5.

📒 Files selected for processing (1)
  • params/config.go

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@FletcherMan FletcherMan merged commit 17af190 into main Mar 13, 2026
8 checks passed
@FletcherMan FletcherMan deleted the feat/set-jade-fork-times branch March 13, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants