Skip to content

Emerald fork time#269

Merged
FletcherMan merged 2 commits intomainfrom
emerald_fork_time
Dec 17, 2025
Merged

Emerald fork time#269
FletcherMan merged 2 commits intomainfrom
emerald_fork_time

Conversation

@FletcherMan
Copy link
Copy Markdown
Collaborator

@FletcherMan FletcherMan commented Dec 17, 2025

1. Purpose or design rationale of this PR

Set Emerald fork time for mainnet and hoodi network

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • New Features

    • Added Emerald fork timing support for blockchain networks.
  • Chores

    • Updated Go runtime to version 1.24.
    • Version bumped to 0.1.0.

✏️ Tip: You can customize this high-level summary in your review settings.

@FletcherMan FletcherMan requested a review from a team as a code owner December 17, 2025 03:57
@FletcherMan FletcherMan requested review from Web3Jumb0 and removed request for a team December 17, 2025 03:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 17, 2025

Walkthrough

This PR updates the Go builder base image from 1.21-alpine to 1.24-alpine, adds EmeraldTime fork timing fields to MorphHoodi and MorphMainnet chain configurations, and bumps the semantic version to v0.1.0.

Changes

Cohort / File(s) Summary
Build Environment
Dockerfile
Upgrades Go builder stage base image from golang:1.21-alpine to golang:1.24-alpine while preserving all build steps.
Chain Configuration
params/config.go
Adds EmeraldTime uint64 timestamp field to MorphHoodiChainConfig and MorphMainnetChainConfig initializations, establishing Emerald fork timing.
Version Bumping
params/version.go
Updates semantic version constants: VersionMinor incremented from 0 to 1 and VersionPatch reset from 8 to 0; derived version strings automatically reflect changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward base image upgrade with no logic changes
  • Configuration field additions are localized and declarative
  • Version bump is mechanical constant update

Possibly related PRs

  • add emerald configs #246: Adds OverrideEmeraldTime flag and config usage in genesis setup, directly complementing these EmeraldTime config values.
  • Add emerald upgrade #216: Introduces and uses the EmeraldTime ChainConfig field that this PR populates for specific chains.
  • Sync the commits to main #202: Concurrently updates params/version.go (semantic versioning) and params/config.go (chain configuration fields).

Suggested reviewers

  • Web3Jumb0
  • curryxbo

Poem

🐰 Hops of joy for fresh alpine skies,
Emerald times in config ties,
Version bumps with patchwork care,
Go 1.24—smooth everywhere!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Emerald fork time' clearly and directly describes the main change in the PR: adding Emerald fork timing for mainnet and Hoodi network configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch emerald_fork_time

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9217e7b and 859c7c8.

📒 Files selected for processing (3)
  • Dockerfile (1 hunks)
  • params/config.go (2 hunks)
  • params/version.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (go)
🔇 Additional comments (4)
params/version.go (1)

26-27: LGTM! Version bump follows semantic versioning.

The version is correctly incremented from 2.0.8 to 2.1.0, reflecting the addition of the Emerald fork as a new minor feature. The patch version is appropriately reset to 0.

Dockerfile (1)

7-7: golang:1.24-alpine is available and valid.

Go 1.24 was released on February 11, 2025, and the golang:1.24-alpine Docker image is available on Docker Hub. The base image does not require verification as it has been publicly available for months.

params/config.go (2)

350-350: EmeraldTime timestamp for MorphMainnet is correct.

The EmeraldTime is set to 1767765600 (2026-01-07 06:00:00 UTC), which is approximately 65 days after ViridianTime (2025-11-03 06:00:00 UTC). The timestamp is future-dated relative to the network, follows the intended fork schedule progression (Morph203Time → ViridianTime → EmeraldTime), and is properly ordered chronologically.


319-319: EmeraldTime timestamp verified as correct.

The EmeraldTime value of 1766988000 (2025-12-29 06:00:00 UTC) is valid:

  • 12 days in the future from current date (2025-12-17)
  • Chronologically after ViridianTime (1761544800 → 2025-10-27)
  • Maintains a 63-day gap between fork activations, consistent with the fork schedule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FletcherMan FletcherMan merged commit 08fa19d into main Dec 17, 2025
8 checks passed
@FletcherMan FletcherMan deleted the emerald_fork_time branch December 17, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants