Replace os.path in storage module #30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 51.04% 51.12% +0.07%
==========================================
Files 9 9
Lines 764 757 -7
==========================================
- Hits 390 387 -3
+ Misses 374 370 -4
Continue to review full report at Codecov.
|
| except Exception as e: | ||
| shutil.rmtree(self._image_dir) | ||
| self._image_dir.mkdir() | ||
| except IOError as e: | ||
| logger.warning("Error clearing image directory: %s", e) |
There was a problem hiding this comment.
f-strings while we are here?
There was a problem hiding this comment.
There's lots of modulo formatting in this file, so I opted to not change anything more than the lines I changed anyway.
| path = os.path.join(root, name) | ||
| logger.info("Deleting file %s", path) | ||
| os.remove(path) | ||
| for image_path in self._image_dir.glob("**/*"): |
There was a problem hiding this comment.
Note Using the “**” pattern in large directory trees may consume an inordinate amount of time.
Should we be using glob.iglob or are we going to have this problem anyway. Same would go for any other uses of glob.
There was a problem hiding this comment.
I guess that note mostly refers to "if you run this on something unknown, you don't know how long it will take". We only use it on dirs we've built ourselves. The size of this directory tree isn't any larger than the number of albums in your local music collection.
PR #29 replaced all the
os.pathusage in the scanner. This finishes the work by replacing allos.pathusage in the storage module, and thus fixes #20.