Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanner improvements #29

Merged
merged 23 commits into from
Jan 3, 2020
Merged

Scanner improvements #29

merged 23 commits into from
Jan 3, 2020

Conversation

jodal
Copy link
Member

@jodal jodal commented Jan 1, 2020

I started out with the goal of removing the mopidy.internal.path usage from the scanner, but I ended up with a bit more.

Review commit by commit is recommended.

@jodal jodal added this to the v3.0.1 milestone Jan 1, 2020
@jodal jodal requested review from adamcik and tkem January 1, 2020 23:07
@jodal jodal self-assigned this Jan 1, 2020
@codecov
Copy link

codecov bot commented Jan 1, 2020 •
edited
Loading

Codecov Report

Merging #29 into master will increase coverage by 0.25%.
The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   50.79%   51.04%   +0.25%     
==========================================
  Files           9        9              
  Lines         754      764      +10     
==========================================
+ Hits          383      390       +7     
- Misses        371      374       +3
Impacted Files Coverage Δ
mopidy_local/commands.py 0% <0%> (ø) ⬆️
mopidy_local/translator.py 100% <100%> (+16.66%) ⬆️
mopidy_local/storage.py 44.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152a0e1...1d7da69. Read the comment docs.

adamcik
adamcik approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@adamcik adamcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but the disabled tests should be addressed here or in a follow-pr before a release.

kingosticks
kingosticks approved these changes Jan 2, 2020
View reviewed changes
@kingosticks
Copy link
Member

Looks good to me

@jodal jodal modified the milestones: v3.0.1, v3.1.0 Jan 2, 2020
@jodal jodal mentioned this pull request Jan 2, 2020
Closed
@jodal
Copy link
Member Author

jodal commented Jan 2, 2020

@kingosticks @adamcik Can you have a look at the new commits too?

@kingosticks
Copy link
Member

Couple of minor things but LGTM

@jodal jodal merged commit 9f5872c into mopidy:master Jan 3, 2020
@jodal jodal deleted the scanner-improvements branch January 3, 2020 18:53
@jodal jodal mentioned this pull request Jan 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingosticks kingosticks kingosticks approved these changes

@adamcik adamcik adamcik approved these changes

@tkem tkem Awaiting requested review from tkem

Assignees

@jodal jodal

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jodal @kingosticks @adamcik