-
Notifications
You must be signed in to change notification settings - Fork 2
Update dependencies to stable2503 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -349,7 +349,7 @@ where | |
| Some(WarpSyncConfig::WithProvider(warp_sync)) | ||
| }; | ||
|
|
||
| let (network, system_rpc_tx, tx_handler_controller, network_starter, sync_service) = | ||
| let (network, system_rpc_tx, tx_handler_controller, sync_service) = | ||
| sc_service::build_network(sc_service::BuildNetworkParams { | ||
| config: &config, | ||
| net_config, | ||
|
|
@@ -533,7 +533,6 @@ where | |
| commands_stream, | ||
| )?; | ||
|
|
||
| network_starter.start_network(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if this could have further implications. Can you look into other parts of the polkadot-sdk/frontier code and check how they managed this change (if they did)?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to be automatically started now |
||
| log::info!("Manual Seal Ready"); | ||
| return Ok(task_manager); | ||
| } | ||
|
|
@@ -632,7 +631,6 @@ where | |
| .spawn_blocking("grandpa-voter", None, grandpa_voter); | ||
| } | ||
|
|
||
| network_starter.start_network(); | ||
| Ok(task_manager) | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what is this second param for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! the second param is an
EventHandler