Update dependencies to stable2503#4
Closed
dimartiro wants to merge 4 commits intotanssi-polkadot-stable2503from
Closed
Update dependencies to stable2503#4dimartiro wants to merge 4 commits intotanssi-polkadot-stable2503from
dimartiro wants to merge 4 commits intotanssi-polkadot-stable2503from
Conversation
Agusrodri
reviewed
May 13, 2025
|
|
||
| pub use self::{execute::EstimateGasAdapter, filter::EthFilter}; | ||
|
|
||
| type Pool<Api> = sc_transaction_pool::Pool<Api, ()>; |
There was a problem hiding this comment.
Do you know what is this second param for?
| commands_stream, | ||
| )?; | ||
|
|
||
| network_starter.start_network(); |
There was a problem hiding this comment.
I wonder if this could have further implications. Can you look into other parts of the polkadot-sdk/frontier code and check how they managed this change (if they did)?
Author
There was a problem hiding this comment.
It seems to be automatically started now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependencies updated to
tanssi-polkadot-stable2503Some changes
DecodeWithMemTrackingadded for some typessc_transaction_pool::Poolreceive 2 generics now, so I'm using()to ignore the second onesc_service::build_networkreturns a touple of 4 arguments instead of 5 so I had to remove thenetwork_starterNote: I'm temporary using my fork of
evmwhile the changes I need are approved in upsteam