Skip to content

Roll out base_extrinsic_weight to all runtimes#1946

Merged
notlesh merged 3 commits intomasterfrom
notlesh-base-extrinsic-weight-all-runtimes
Nov 11, 2022
Merged

Roll out base_extrinsic_weight to all runtimes#1946
notlesh merged 3 commits intomasterfrom
notlesh-base-extrinsic-weight-all-runtimes

Conversation

@notlesh
Copy link
Contributor

@notlesh notlesh commented Nov 10, 2022

What does it do?

Rolls out base_extrinsic_weight to Moonriver and Moonbeam runtimes.

This same change was introduced to Moonbase runtimes in #1576.

⚠️ Breaking Changes ⚠️

⚠️ All substrate-based fees on moonriver and moonbeam runtimes will be impacted by this
⚠️ Some txns in the mempool prior to this change (runtime upgrade) may become invalid
⚠️ RPC calls to estimate fees will return different values

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. I5-documentation 📄 Documentation needs fixing, improving or augmenting. labels Nov 10, 2022
@notlesh notlesh merged commit 2dd83a2 into master Nov 11, 2022
@notlesh notlesh deleted the notlesh-base-extrinsic-weight-all-runtimes branch November 11, 2022 17:37
@notlesh notlesh mentioned this pull request Nov 11, 2022
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 14, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
)

* Add customized extrinsic_base_weight to moonriver/moonbeam

* fmt

* Update test fee expectations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited I5-documentation 📄 Documentation needs fixing, improving or augmenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants